This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Data-configuration: introduced ingress/egress data slices #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordigilh
requested review from
masayag,
eloycoto,
pkliczewski,
jakub-dzon and
bardielle
jordigilh
changed the title
jordigilh
commented
May 25, 2022
vendor/github.com/project-flotta/flotta-operator/models/data_configuration.go
Show resolved
Hide resolved
jordigilh
force-pushed
the
add_bidirectional_data_transfer
branch
2 times, most recently
from
6ecd1fd to
8770cfd
Compare
These libraries were introduced recently in commit f63ab085f9f57ea830393250d0dec4b01d3ee805 for logging and multierror. I'm adding them in this commit as part of the results of running `go mod vendor`.
jordigilh
force-pushed
the
add_bidirectional_data_transfer
branch
from
8770cfd to
1739605
Compare
…un go mod vendor to update vendor library for flotta-operator
jordigilh
force-pushed
the
add_bidirectional_data_transfer
branch
from
1739605 to
64ce89d
Compare
jordigilh
changed the title
jakub-dzon
suggested changes
May 26, 2022
jakub-dzon
approved these changes
May 27, 2022
masayag
approved these changes
May 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an ingress/egress slice for data paths in the workload's data configuration.
Even though the PR is on hold due to dependencies to the swagger changes in the flotta operator, the code changes that handle the new flows are implemented, so feel free to review at your discretion it while the other PR is being considered.
Note that the sync process does not delete data at the target destination when the source gets deleted. This is already by configuration for S3 syncs, not something included in this PR.