Skip to content

Add make target that simplifies build-push-deployment to cluster #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Sep 20, 2023

Issue link

Closes #638

What changes have been made

The easy-deploy make target can be used for building and pushing a custom image of MCAD and deploying it on your K8s cluster for development.

Verification steps

Example: make easy-deploy TAG=yourtag USERNAME=rh_ee_jdoe

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Manual tests

@VanillaSpoon
Copy link
Contributor

I like this :)
Works as expected. Only nit I would have is easy-push to me would suggest a quick image build and push, but this also deploys. So maybe make easy-deploy or make easy-custom-deploy?

lgtm other than that but I'll leave it open for more feedback

@ChristianZaccaria
Copy link
Contributor Author

I like this :) Works as expected. Only nit I would have is easy-push to me would suggest a quick image build and push, but this also deploys. So maybe make easy-deploy or make easy-custom-deploy?

lgtm other than that but I'll leave it open for more feedback

Yeah I agree, nice one thanks!

I guess make easy-deploy makes more sense as that is the end goal of this make target.

@Fiona-Waters
Copy link
Contributor

I really like this too. Tested on an OSD cluster and it works as expected.
You could possibly also add a section on the command here https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md or to the main readme.
/lgtm

@ChristianZaccaria
Copy link
Contributor Author

ChristianZaccaria commented Sep 25, 2023

I really like this too. Tested on an OSD cluster and it works as expected. You could possibly also add a section on the command here https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md or to the main readme. /lgtm

That's a great idea! Thanks @Fiona-Waters. Will do asap

@ChristianZaccaria
Copy link
Contributor Author

@Fiona-Waters I added documentation on the Readme (for quick deployment), and on the deployment doc. Let me know what you think :) Thanks!

Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ChristianZaccaria :)

@Fiona-Waters
Copy link
Contributor

@Fiona-Waters I added documentation on the Readme (for quick deployment), and on the deployment doc. Let me know what you think :) Thanks!

Looks great! :)
/lgtm

@ChristianZaccaria
Copy link
Contributor Author

ChristianZaccaria commented Oct 12, 2023

@anishasthana Hi, could we get this merged please? It's from last sprint :) [MCAD]

Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, VanillaSpoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit baca4eb into project-codeflare:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify image build, push, and deployment (all-in-one)
4 participants