-
Notifications
You must be signed in to change notification settings - Fork 64
Add make target that simplifies build-push-deployment to cluster #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make target that simplifies build-push-deployment to cluster #639
Conversation
I like this :) lgtm other than that but I'll leave it open for more feedback |
defbfa2
to
709b679
Compare
Yeah I agree, nice one thanks! I guess |
709b679
to
1befb2d
Compare
I really like this too. Tested on an OSD cluster and it works as expected. |
That's a great idea! Thanks @Fiona-Waters. Will do asap |
1befb2d
to
98f5bda
Compare
@Fiona-Waters I added documentation on the Readme (for quick deployment), and on the deployment doc. Let me know what you think :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @ChristianZaccaria :)
Looks great! :) |
@anishasthana Hi, could we get this merged please? It's from last sprint :) [MCAD] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, VanillaSpoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Closes #638
What changes have been made
The
easy-deploy
make target can be used for building and pushing a custom image of MCAD and deploying it on your K8s cluster for development.Verification steps
Example:
make easy-deploy TAG=yourtag USERNAME=rh_ee_jdoe
Checks