-
Notifications
You must be signed in to change notification settings - Fork 64
reduce threads #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce threads #582
Conversation
logs for test passing locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are a lot of things that need to be addressed. Some things are meant to be temporarily changed, but in a lot of cases no explicit tag (e.g., TODO) is added to remember that. I just want to make sure these things are addressed and won't remain in the code in the future.
I have created relevant GitHub issues. the todos have not been introduced by this PR rather they are discovered and now annotated in the code base |
This reverts commit dbbf187.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalcycling The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
#510 #579
What changes have been made
Reduced threads inside MCAD
Verification steps
Checks