Skip to content

reduce threads #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 17, 2023
Merged

Conversation

asm582
Copy link
Member

@asm582 asm582 commented Aug 15, 2023

Issue link

#510 #579

What changes have been made

Reduced threads inside MCAD

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@asm582
Copy link
Member Author

asm582 commented Aug 15, 2023

logs for test passing locally:

inc_perf_3_kuttl_2.log
inc_perf_3.log

@asm582 asm582 marked this pull request as ready for review August 16, 2023 22:21
@openshift-ci openshift-ci bot requested review from astefanutti and z103cb August 16, 2023 22:21
@asm582 asm582 requested review from metalcycling and removed request for z103cb August 16, 2023 22:48
Copy link
Collaborator

@metalcycling metalcycling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are a lot of things that need to be addressed. Some things are meant to be temporarily changed, but in a lot of cases no explicit tag (e.g., TODO) is added to remember that. I just want to make sure these things are addressed and won't remain in the code in the future.

@asm582
Copy link
Member Author

asm582 commented Aug 17, 2023

It seems there are a lot of things that need to be addressed. Some things are meant to be temporarily changed, but in a lot of cases no explicit tag (e.g., TODO) is added to remember that. I just want to make sure these things are addressed and won't remain in the code in the future.

I have created relevant GitHub issues. the todos have not been introduced by this PR rather they are discovered and now annotated in the code base

Copy link
Collaborator

@metalcycling metalcycling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalcycling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asm582 asm582 requested a review from anishasthana August 17, 2023 17:48
@openshift-merge-robot openshift-merge-robot merged commit f34e1f5 into project-codeflare:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants