Format release notes with github script #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Website deployed to CF Pages, 👀 preview link https://317ebc44.flowzone.pages.dev |
klutchell
force-pushed
the
kyle/format-release-notes
branch
from
62cea49 to
9ce7e67
Compare
klutchell
force-pushed
the
kyle/format-release-notes
branch
from
9ce7e67 to
b083205
Compare
klutchell
force-pushed
the
kyle/format-release-notes
branch
from
b083205 to
f7e5be7
Compare
|
#release-notes Format release notes with github script Notable changes
|
klutchell
force-pushed
the
kyle/format-release-notes
branch
from
8be35f6 to
d2d1cbc
Compare
The previous function was throwing errors in some cases when the gh cli expected a local .git directory. Instead we should avoid an interactive CLI for steps like this. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/format-release-notes
branch
from
d2d1cbc to
8432821
Compare
pipex
reviewed
Apr 7, 2025
|
|
||
| // Handle custom release notes | ||
| const customReleaseNotesMatch = pr.body.match(/## Release Notes([\s\S]*?)(?=## |$)/i); | ||
| console.log('match:', JSON.stringify(customReleaseNotesMatch, null, 2)); |
There was a problem hiding this comment.
Did you intend to leave this here?
There was a problem hiding this comment.
I mean it's not UNhelpful, but we can remove it if you think it's messy.
There was a problem hiding this comment.
It doesn't bother me, I was just wondering if it was intentional
There was a problem hiding this comment.
Yeah, those ones were
pipex
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous function was throwing errors in some cases when the gh cli expected a local .git directory.
Instead we should avoid an interactive CLI for steps like this.
Tested with both custom release notes (below) and Renovate-style release notes here.
Release Notes
Format release notes with github script to avoid interactive CLI errors at runtime.