Skip to content

Add Unified Push support (via Conversations/up) #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

itd0
Copy link
Contributor

@itd0 itd0 commented Jun 7, 2025

As suggested in processone/ejabberd-contrib#363, this PR upstreams the support for the stanzas used by Conversations/up to provide Unified Push.

The CLA links in CONTRIBUTING.md produced 404s for me.

@p1bot
Copy link
Collaborator

p1bot commented Jun 7, 2025

Hi @itd0, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@p1bot p1bot added the cla-missing Contributor needs to sign Contribution License Agreement label Jun 7, 2025
@itd0
Copy link
Contributor Author

itd0 commented Jun 7, 2025

@p1bot,

In order for us to evaluate and accept your PR, we ask that you [sign a contribution license agreement](https://09e8eb57bde4). It's all electronic and will take just minutes.

that URL looks a bit odd.

@badlop
Copy link
Member

badlop commented Jun 9, 2025

@p1bot,

In order for us to evaluate and accept your PR, we ask that you [sign a contribution license agreement](https://09e8eb57bde4). It's all electronic and will take just minutes.

that URL looks a bit odd.

Oops, that URL includes only the query part, and is missing the domain and the path! I've reported to the webadmin, I guess in the next days he will fix it.

@badlop
Copy link
Member

badlop commented Jun 9, 2025

Some of the files tracked in this git repository are automatically derivated from source material. Ideally, such derivated content should not be committed a tthe same time that the source material that originated it.

For example, in this commit I modified the spec file. Then GitHub Action takes care to produce derivated content and commit automatically in a separate commit with just that resulting code.

In summary: can you please include in your commit (and PR) only the original changes that you made, and exclude the derivated changes? In practice this means including xmpp_codec.spec and excluding xmpp_codec.hrl, unifiedpush.erl and xmpp_codec.erl.

Support iq/register stanzas as used by Conversations [1] and up [2].

[1]: https://codeberg.org/iNPUTmice/Conversations
[2]: https://codeberg.org/iNPUTmice/up#registration
@itd0 itd0 force-pushed the itd0/unified-push branch from 3f178b8 to 7d19bad Compare June 10, 2025 12:45
@itd0
Copy link
Contributor Author

itd0 commented Jun 10, 2025

In summary: can you please include in your commit (and PR) only the original changes that you made, and exclude the derivated changes? In practice this means including xmpp_codec.spec and excluding xmpp_codec.hrl, unifiedpush.erl and xmpp_codec.erl.

Thanks for the guidance. Hope the latest commit matches the requirements.

@p1bot
Copy link
Collaborator

p1bot commented Jun 12, 2025

You did it @itd0!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

@p1bot p1bot removed the cla-missing Contributor needs to sign Contribution License Agreement label Jun 12, 2025
@badlop badlop merged commit 46af606 into processone:master Jun 12, 2025
5 checks passed
badlop added a commit to processone/ejabberd that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants