Unwrap default exports in CJS under default property #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Would you mind adding a small test to lock this behavior in? |
|
Yes certainly! I wanted to and got destracted by something else. Will add soon. 👍 |
|
@privatenumber ok test is in, this should be ready to go. |
|
I'm in favor of this change, but this is breaking for anyone that is relying on the current behavior and is doing Going to hold this for a bit but I think we'll cut a major release soon. |
|
Makes sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
Injecting helpers that contain code that detects at runtime if the required value contains the __esModule property.