-
Notifications
You must be signed in to change notification settings - Fork 49
Privacy Sandbox attestation files for Service Provider #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy Sandbox attestation files for Service Provider #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Seburan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue with the Privacy Sandbox attestation files for the Service Provider. Specifically, it fixes the attestation filename and updates the attestation file content for the new service provider. The changes involve replacing placeholder content with actual JSON attestation data in both the development and production environments.
Highlights
- Attestation File Update: The primary change involves updating the privacy sandbox attestation files for the Service Provider in both development and production environments.
- Filename Correction: The pull request also ensures the attestation filename is correct for the new service provider.
- Content Replacement: Placeholder content in the attestation files is replaced with actual JSON attestation data, including details about privacy policies, ownership tokens, and platform attestations.
Changelog
- cicd/attestations/privacy-sandbox-attestations.json.service-provide.prod
- Replaced placeholder content with JSON attestation data for the production environment.
- The new content includes details about privacy policies, ownership tokens, enrollment ID, and platform attestations for Chrome and Android (lines 1-35).
- cicd/attestations/privacy-sandbox-attestations.json.service-provider.dev
- Replaced placeholder content with JSON attestation data for the development environment.
- The new content includes details about privacy policies, ownership tokens, enrollment ID and site, and platform attestations for Chrome and Android (lines 1-35).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
In JSON's embrace,
Attestations find their place,
Privacy takes flight.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces attestation files for the Service Provider in both development and production environments. The changes involve adding JSON files with specific configurations related to Privacy Sandbox APIs. Overall, the structure and content of the files seem reasonable, but there are a few points to consider.
Merge Readiness
The pull request introduces new attestation files, which is a critical step for enabling Privacy Sandbox features. Before merging, it's essential to ensure that the configurations are accurate and aligned with the service provider's intended usage of the Privacy Sandbox APIs. I am unable to approve the pull request in any circumstance, and users should have others review and approve this code before merging. Given the importance of these files, I recommend a thorough review and validation of the configurations before merging.
Description
fix attestation filename and attestation file content for new service-provider
Affected services
Other: