Feature/bidding and auction

[chasinandrew]

Prior to creating a pull request, please follow all the steps in the contributing guide.

Please describe a summary of the changes.

Related Issue

• Fix for contextual flow

Affected services

• Home
• News
• Shop
• Travel
• DSP
• SSP
• ALL

Other:

[gemini-code-assist]

Hello @chasinandrew, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request appears to implement bidding and auction functionalities, specifically for the DSP service. The changes involve modifying how the protected audience auction result is handled and updating the contextual bid URLs for DSP A and DSP B.

Highlights

• Data Type Conversion: The protectedAudienceAuctionResult is now explicitly converted to a Uint8Array after decoding the response. This ensures the data is in the expected format for further processing.
• Bid URL Update: The bid URLs for DSP A and DSP B in the contextual auction route have been updated to /dsp/contextual-bid-ba. This likely points to a new or modified endpoint for handling contextual bids.

Changelog

• services/ad-tech/src/public/js/ssp/usecase/bidding-and-auction/ssp-x/construct-component-auction.ts
  • The protectedAudienceAuctionResult is now explicitly converted to a Uint8Array after decoding the response. Line 84 was changed to reflect this.
• services/ad-tech/src/routes/ssp/usecase/bidding-and-auction/bidding-and-auction-router.ts
  • The bid URLs for DSP A and DSP B in the contextual auction route have been updated to /dsp/contextual-bid-ba. Lines 111 and 114 were changed to reflect this.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A bid is placed, an auction starts,
Code reviews play critical parts.
To check each line,
Make sure it's fine,
And fix all bugs before they depart.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces changes to the bidding and auction process, specifically focusing on contextual auctions and protected audience auctions. The changes involve modifying URLs for DSP bidders and adjusting how auction results are handled. Overall, the changes seem reasonable, but there are a few points that need attention.

Summary of Findings

• Type Conversion: The conversion of the decoded response to Uint8Array might not be necessary and could potentially introduce performance overhead. Consider if the original type is sufficient for subsequent operations.
• URL Consistency: The change in the contextual bid URL from /dsp/contextual-bid to /dsp/contextual-bid-ba for DSP A and DSP B should be consistent across the codebase and reflect the intended behavior. Verify that this change is intentional and doesn't introduce any regressions.

Merge Readiness

The pull request introduces important changes to the bidding and auction process. While the changes seem reasonable, the identified issues regarding type conversion and URL consistency should be addressed before merging. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

[Seburan]

lgtm