Skip to content

remove TODOs and graph source code #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sinnew opened this issue Apr 18, 2025 · 0 comments
Closed

remove TODOs and graph source code #623

sinnew opened this issue Apr 18, 2025 · 0 comments
Assignees

Comments

@sinnew
Copy link
Contributor

sinnew commented Apr 18, 2025

user journey diagram code made into the doc. + there's TODO item left.

https://github.com/privacysandbox/privacy-sandbox-demos/blame/ff68148e0987979ecdac2f0183b9ca2a1b847bcc/services/home/docs/demos/bidding-and-auction.md#L91

Seburan added a commit that referenced this issue Apr 18, 2025
- fix issue #624
- fix issue #623
- fix issue #622
- fix issue #621
@Seburan Seburan mentioned this issue Apr 18, 2025
7 tasks
sinnew pushed a commit that referenced this issue Apr 21, 2025
* demo docs fixes :
- fix issue #624
- fix issue #623
- fix issue #622
- fix issue #621

Documentation Fixes: The PR resolves multiple documentation issues by fixing relative file paths and URLs in the markdown files. It also updates image links to use relative paths instead of absolute URLs.
Docusaurus Configuration: The Docusaurus configuration is updated to throw an exception when Markdown links are broken, ensuring link integrity. The trailingSlash option is enabled to add trailing slashes to URLs.
Nginx Configuration: The Nginx configuration is strengthened by upgrading Nginx to version 1.27.5-alpine and adding directives for security and optimization. The configuration file is now directly copied to /etc/nginx/nginx.conf instead of using a template.
Docker Compose Update: The docker-compose.yml file is updated to use the newer Nginx image version 1.27.5-alpine.


Markdown file paths are preferred. see https://docusaurus.io/docs/next/markdown-features/links

updated docusaurus config to throw an exception when Markdown links are broken

* [home] strenghten nginx configuration

upgrade nginx
add nginx.conf directives for security and optimization

* fix docs

link to full sized image hosted on Github
sinnew added a commit that referenced this issue Apr 22, 2025
* add uint array back
* fix bug for contextual
* Linter fixes for EJS templates (#618)
* Feature/bidding and auction (#619)

Documentation Updates: The bidding-and-auction.md file has been updated to clarify the demo's goals, assumptions, and key exclusions. The steps have been revised to provide more precise instructions for users.

Console Logging: Console log messages in ssp-a, ssp-x, and ssp-y components have been modified to provide more context about the auction configurations.

Code Cleanup: Unnecessary code related to encoding requests has been removed from ssp-y/construct-component-auction.ts.

* Bugfix/bna demo for April 18th release (#617)

* [docker-compose] ad network configuration

Setting network configuration to allow integration with bidding and auction demo.
Privacy Sandbox Demos will use 172.16.128.0/24 range to not collide with Bidding and Auction services with fixed ips on 172.16.0.0/24

* package.json scripts

- update start command to be able to refresh a specific service. use `npm run start -- [service-name]`
- update stop command to remove volumes
- update build command to build without cache

* docker-compose : fix race condition on ad-tech services

ad-tech services are using the same codebase and were all mounting the local ./services/ad-tech folder causing race conditions. Often one of the ad-tech services would not start properly. as a temporary workaround we are removing the filesystem mounted volume.

* Bugfix/mmt-multi-touch (#620)

* add xxx-news services in firebase for Multi Touch Attribution Demo

* multi-touch attribution demo doc : update link

* fix firebase_deploy.sh

* Bugfix/home docs (#626)

* demo docs fixes :
- fix issue #624
- fix issue #623
- fix issue #622
- fix issue #621

Documentation Fixes: The PR resolves multiple documentation issues by fixing relative file paths and URLs in the markdown files. It also updates image links to use relative paths instead of absolute URLs.
Docusaurus Configuration: The Docusaurus configuration is updated to throw an exception when Markdown links are broken, ensuring link integrity. The trailingSlash option is enabled to add trailing slashes to URLs.
Nginx Configuration: The Nginx configuration is strengthened by upgrading Nginx to version 1.27.5-alpine and adding directives for security and optimization. The configuration file is now directly copied to /etc/nginx/nginx.conf instead of using a template.
Docker Compose Update: The docker-compose.yml file is updated to use the newer Nginx image version 1.27.5-alpine.


Markdown file paths are preferred. see https://docusaurus.io/docs/next/markdown-features/links

updated docusaurus config to throw an exception when Markdown links are broken

* [home] strenghten nginx configuration

upgrade nginx
add nginx.conf directives for security and optimization

* fix docs

link to full sized image hosted on Github

* [home] Reintroduce nginx.conf.template (#628)

Allows env vars (PORT) in nginx conf

---------

Co-authored-by: chasinandrew <[email protected]>
Co-authored-by: Severin FERRAND <[email protected]>
Co-authored-by: Sid Sahoo <[email protected]>
@sinnew sinnew closed this as completed Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants