Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(blog)!: Clearing Your Browsing Data #2878

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

kpham42
Copy link
Contributor

@kpham42 kpham42 commented Feb 4, 2025

List of changes proposed in this PR:

-added article about clearing browsing data on Firefox, Chrome, Brave, Edge, and Safari.
-added Kevin to authors yaml file
-uploaded images to assets folder

Closes https://github.com/privacyguides/article-ideas/issues/9

Copy link

github-actions bot commented Feb 4, 2025

Your preview is ready!

Name Link
🔨 Latest commit 6e47043
😎 Preview https://pr2878.unreviewed.privacyguides.dev/en/

Please note that this preview was built from an untrusted source, so it was not granted access to all mkdocs-material features. Maintainers should ensure this PR has been reviewed locally with a full build before merging.

@kpham42
Copy link
Contributor Author

kpham42 commented Feb 4, 2025

I need someone to add the ci:build blog label for me. I don't have triage access

@redoomed1 redoomed1 added c:blog relating to privacyguides.org/blog ci:build blog Enable blog builds on a PR labels Feb 5, 2025
@redoomed1 redoomed1 changed the title update(blog): Clearing Your Browsing Data update(blog)!: Clearing Your Browsing Data Feb 5, 2025
Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpham42 I think the build process failed because the username you added to .authors.yml doesn't match the one under authors in your blog post (line 7). I just want to let you know and let you decide what username you want to keep.

@kpham42
Copy link
Contributor Author

kpham42 commented Feb 6, 2025

@kpham42 I think the build process failed because the username you added to .authors.yml doesn't match the one under authors in your blog post (line 7). I just want to let you know and let you decide what username you want to keep.

fixed!

Copy link
Member

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @kpham42 ! Quick headsup, do not forgot to edit the date metadata to the day where this blog post goes online :).

@kpham42
Copy link
Contributor Author

kpham42 commented Feb 10, 2025

I accidentally merged another PR into this branch. Please ignore :/

@jonaharagon jonaharagon merged commit 6e47043 into privacyguides:main Feb 13, 2025
12 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/2025-02-14/24973/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:blog relating to privacyguides.org/blog ci:build blog Enable blog builds on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants