Skip to content

Updates IconButton previews to be keyboard accessible #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

lindseywild
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Similar to #2802, ensures that the IconButton previews are keyboard accessible

Integration

No

List the issues that this change affects.

Related to https://github.com/github/primer/issues/2190

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Used the same approach in #2802, where I conditionally add an href attribute if an element's tag is a link, removed <summary> from being an option in most instances since it requires a wrapping <details> element, and added new previews for links and summarys.

Anything you want to highlight for special attention from reviewers?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@lindseywild lindseywild requested a review from a team as a code owner June 3, 2024 11:10
Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: e421a6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lindseywild lindseywild added the skip changeset Pull requests that don't change the library output label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@github-actions github-actions bot requested a review from a team as a code owner June 3, 2024 11:15
@github-actions github-actions bot requested a review from emilybrick June 3, 2024 11:15
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ⚡

@jonrohan jonrohan enabled auto-merge (squash) June 3, 2024 15:16
@jonrohan jonrohan merged commit fcf7621 into main Jun 3, 2024
30 of 31 checks passed
@jonrohan jonrohan deleted the lw/fix-iconbutton-preview branch June 3, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants