Skip to content

fix: tinyexec v1 is esm only, use 0.x instead temporarily #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jun 2, 2025

Important

Downgrade tinyexec to ^0.3.2 in package.json due to ESM-only support in version 1.x.

  • Dependencies:
    • Downgrade tinyexec from ^1.0.1 to ^0.3.2 in package.json due to ESM-only support in version 1.x.

This description was created by Ellipsis for 88fef75. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Bug Fixes

    • Resolved compatibility issues by reverting the "tinyexec" dependency to an earlier version.
  • Chores

    • Updated documentation to reflect the dependency change.

@JounQin JounQin requested a review from Copilot June 2, 2025 10:39
@JounQin JounQin self-assigned this Jun 2, 2025
@JounQin JounQin added the bug Something isn't working label Jun 2, 2025
Copy link

changeset-bot bot commented Jun 2, 2025

🦋 Changeset detected

Latest commit: c088d05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pretty-quick Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Jun 2, 2025

Walkthrough

This change downgrades the tinyexec dependency from version 1.x to 0.x in the package.json file and adds a changeset documenting this adjustment. The update addresses compatibility issues caused by the newer ESM-only release of tinyexec.

Changes

File(s) Change Summary
package.json Downgraded tinyexec dependency from ^1.0.1 to ^0.3.2.
.changeset/good-cougars-obey.md Added changeset describing the temporary downgrade of tinyexec.

Possibly related PRs

Suggested labels

dependencies

Poem

A rabbit hopped to fix the code,
Downgraded tinyexec, lightened the load.
ESM-only woes, now set aside,
With version 0.x, we smoothly ride.
🐇✨
Patch applied, the journey goes on—
Bugs and errors now are gone!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8811559 and c088d05.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .changeset/good-cougars-obey.md (1 hunks)
  • package.json (1 hunks)
🔇 Additional comments (1)
.changeset/good-cougars-obey.md (1)

1-6: Approve changeset documentation
The changeset correctly records this patch-level rollback of tinyexec, adheres to the standard changeset format, and clearly states the rationale for the temporary downgrade.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JounQin JounQin changed the title fix: tinyexec v1 is esm only fix: tinyexec v1 is esm only, use 0.x instead temporarily Jun 2, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the tinyexec dependency from v1.x back to v0.3.x to regain CommonJS support and avoid ESM-only behavior.

  • Downgrade tinyexec from ^1.0.1 to ^0.3.2
  • Preserve existing CommonJS compatibility

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 88fef75 in 50 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:77
  • Draft comment:
    Downgrade tinyexec to ^0.3.2 for CommonJS compatibility (v1 is ESM only). Ensure lock files are updated.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_Iq3r9da5w3UmIfke

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

pkg-pr-new bot commented Jun 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/pretty-quick@216

commit: c088d05

Copy link

codesandbox-ci bot commented Jun 2, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (8811559) to head (c088d05).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files           9        9           
  Lines         194      194           
  Branches       44       44           
=======================================
  Hits          169      169           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JounQin JounQin merged commit 71ca04e into master Jun 2, 2025
23 checks passed
@JounQin JounQin deleted the fix/tinyexec branch June 2, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants