-
-
Notifications
You must be signed in to change notification settings - Fork 86
fix: tinyexec v1 is esm only, use 0.x instead temporarily #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c088d05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change downgrades the Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the tinyexec
dependency from v1.x back to v0.3.x to regain CommonJS support and avoid ESM-only behavior.
- Downgrade
tinyexec
from^1.0.1
to^0.3.2
- Preserve existing CommonJS compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 88fef75 in 50 seconds. Click for details.
- Reviewed
13
lines of code in1
files - Skipped
1
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:77
- Draft comment:
Downgrade tinyexec to ^0.3.2 for CommonJS compatibility (v1 is ESM only). Ensure lock files are updated. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_Iq3r9da5w3UmIfke
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
commit: |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 9 9
Lines 194 194
Branches 44 44
=======================================
Hits 169 169
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Important
Downgrade
tinyexec
to^0.3.2
inpackage.json
due to ESM-only support in version 1.x.tinyexec
from^1.0.1
to^0.3.2
inpackage.json
due to ESM-only support in version 1.x.This description was created by
for 88fef75. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Bug Fixes
Chores