-
Notifications
You must be signed in to change notification settings - Fork 125
Document some more movement action functions #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any comments about the choice of names for the scripting macros. This looks great, and thanks for doing this! 🙏
include/unk_020655F4.h
Outdated
void MapObject_DoMovementAction(MapObject *mapObj); | ||
BOOL sub_020658DC(MapObject *mapObj); | ||
|
||
BOOL (*const gMovementActionFuncs_FaceNorth[])(MapObject *); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
polish: Prefix these with extern
.
Sorry for the confusion; I didn't mean to imply that the extern
qualifier should be stripped, just that the declarations should be moved to a header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good pending the polish comment above.
No description provided.