Skip to content

Document some more movement action functions #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2025
Merged

Conversation

cbt6
Copy link
Collaborator

@cbt6 cbt6 commented Jun 4, 2025

No description provided.

@lhearachel lhearachel self-assigned this Jun 7, 2025
Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any comments about the choice of names for the scripting macros. This looks great, and thanks for doing this! 🙏

void MapObject_DoMovementAction(MapObject *mapObj);
BOOL sub_020658DC(MapObject *mapObj);

BOOL (*const gMovementActionFuncs_FaceNorth[])(MapObject *);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polish: Prefix these with extern.

Sorry for the confusion; I didn't mean to imply that the extern qualifier should be stripped, just that the declarations should be moved to a header.

Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good pending the polish comment above.

@lhearachel lhearachel merged commit 8953d19 into pret:main Jun 7, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 7, 2025
@cbt6 cbt6 deleted the movement branch June 8, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants