Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add firestore populate docs #954

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

harveychow
Copy link
Contributor

Description

Docs do mention populate is supported in firestore.md, however the how-to was missing.

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

none

Docs do mention populate is supported in firestore.md, however the how-to was missing.
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #954 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          29       29           
  Lines         797      797           
=======================================
  Hits          704      704           
  Misses         93       93           

@prescottprue prescottprue changed the base branch from master to v3.6.0 June 19, 2020 02:34
@prescottprue prescottprue changed the title Add firestore populate docs feat(docs): add firestore populate docs Jun 19, 2020
@prescottprue prescottprue merged commit e87e4f6 into prescottprue:v3.6.0 Jun 19, 2020
@prescottprue prescottprue mentioned this pull request Jun 19, 2020
3 tasks
prescottprue added a commit that referenced this pull request Jun 19, 2020
* feat(types): add database and firestore statics (#957) - @msutkowski, @themindoverall, @phryneas
* feat(types): add type predicate to `isLoaded` (#956) - @lukeKonopka
* chore(docs): formatting fixes in firestore docs section (#959) - @gregfenton
* feat(docs): add firestore populate docs (#954) - @harveychow

Co-authored-by: gregfenton <[email protected]>
Co-authored-by: Matt Sutkowski <[email protected]>
Co-authored-by: Chris Serino <[email protected]>
Co-authored-by: Harvey Chow <[email protected]>
Co-authored-by: Luke Konopka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants