fix(auth): fix argument type for login with credentials #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderArvidsson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
+ Coverage 88.33% 88.44% +0.11%
==========================================
Files 29 29
Lines 797 805 +8
==========================================
+ Hits 704 712 +8
Misses 93 93 |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Jan 5, 2021
* fix(auth): prevent throw in `logout` when database is not setup (#1042) - @ssdns * fix(types): fix `reloadAuth` argument type and duplicate of `endBefore` (#1031) - @ MatthewDailey * fix(types): fix argument type for `login` with credentials (#1045) - @AlexanderArvidsson * fix(types): add back `FirestoreStatics` to `ExtendedFirestoreInstance` (#1030) * fix(core): add deprecation message `enableLogging` config option * chore(docs): add note about required rules for profile settings (#1049) Co-authored-by: Matthew Dailey <[email protected]> Co-authored-by: Alexander Arvidsson <[email protected]> Co-authored-by: shishido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current typings does not allow you to specify the credential parameter of the credentials in login. This PR changes it to match the implementation.
Check List
If not relevant to pull request, check off as complete