Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Docs - Populate is now supported with Firestore #915

Closed
jakebern opened this issue Apr 18, 2020 · 4 comments · Fixed by #951
Closed

Update Docs - Populate is now supported with Firestore #915

jakebern opened this issue Apr 18, 2020 · 4 comments · Fixed by #951
Labels
needs-repro

Comments

@jakebern
Copy link

https://react-redux-firebase.com/docs/firestore#populate

If I understand correctly, populate works with Firestore - but is not supported with hooks yet (https://github.com/prescottprue/react-redux-firebase/blob/master/docs/api/useFirestoreConnect.md).
@jakebern
Copy link
Author

Source suggesting was supported: https://github.com/prescottprue/redux-firestore#population

@prescottprue
Copy link
Owner

prescottprue commented Apr 23, 2020 •
edited
Loading

Populate should work the same with hooks as it does with HOCs - are you sure you are capturing from state correctly?

Can you provide a code sample to reproduce the populate not working?

As for the docs, it looks like it was updated in the md file and never published, thanks for the heads up

@GautierT
Copy link

Hi.
Probably related to #922 (comment)

@jakebern
Copy link
Author

jakebern commented Apr 27, 2020 •
edited
Loading

@prescottprue Thanks - I was just commenting that the docs seem out of date/inconsistent: (A vs. [B])(https://github.com/prescottprue/react-redux-firebase/blob/master/docs/api/useFirestoreConnect.md)
Screen Shot 2020-04-27 at 8 42 18 AM

I also struggled to figure out how to populate a document with objects in a sub-collection #922 (helpful Gitter thread ongoing - I haven't followed up yet). I'll follow up after doing more digging.

@prescottprue prescottprue mentioned this issue May 31, 2020
Merged
3 tasks
prescottprue added a commit that referenced this issue May 31, 2020
@prescottprue
* fix(docs): remove note about populate not being supported in firest…
f745a79 
…ore - #915

* fix(docs): add correct syntax highlighting to example in firestore.md
@prescottprue prescottprue mentioned this issue May 31, 2020
Merged
3 tasks
prescottprue added a commit that referenced this issue May 31, 2020
@prescottprue @rscotten
@gregfenton @yukimurasawa
v3.5.1 (#951)
8b7aa36 
* fix(types): fix file blob type for uploadFile and uploadFiles (#950) - @rscotten
* chore(docs): cleanup minor typo in useFirestoreConnect.md (#949) - @gregfenton
* chore(tests): fix typo "merge" to "merges" in reducer test file (#948) - @yukimurasawa
* chore(docs): remove note about populate not being supported in firestore (#915)
* chore(examples): clarify explanation in `watchEvent` example snippet (#910)
* chore(docs): add correct syntax highlighting to example in firestore.md
* chore(build): improve lint command
* chore(build): only require jsdoc comments in source

Co-authored-by: Richard Scotten <[email protected]>
Co-authored-by: gregfenton <[email protected]>
Co-authored-by: yukimurasawa <[email protected]>
Co-authored-by: yukimurasawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-repro
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3.5.1 prescottprue/react-redux-firebase
3 participants
@prescottprue @jakebern @GautierT