-
Notifications
You must be signed in to change notification settings - Fork 290
refactor: move fetching of source metadata to command dispatcher #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move fetching of source metadata to command dispatcher #3843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, and it works as expected on my machine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been testing pixi build
with it today, and didn't see anything unexpected. I've also just run all examples and there is no unexpected behavior. I feel confident merging this!
…her (prefix-dev#3843)" We noticed that CI became really slow after we merged this PR. Let's check if that was indeed the problem
This PR replaces the code in the
BuildContext
to fetch source metadata with an implementation in the CommandDispatcher.This involves:
I tested this locally against all the examples in
examples/pixi-build
(and added another one) and verified that locking, relocking, satisfiability and installing still functions as expected.Some things that I changed: