-
Notifications
You must be signed in to change notification settings - Fork 289
feat: add proxy-config and activate https/http proxy for pixi commands #3320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a7f8aee
to
8f06129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! However, Im a little unsure about whether setting the variables into the environment is the best solution. I would prefer to be explicit and pass them into reqwest clients where they are used instead.
8f06129
to
45c6809
Compare
45c6809
to
7efe89b
Compare
@baszalmstra the proxies are now transferred into reqwest::Client, and avoid settting environment vars. |
5bdfba0
to
cd57f7f
Compare
@baszalmstra proxies for uv are also injected into its inner reqwest client.
|
cd57f7f
to
997e0b0
Compare
@baszalmstra is there other suggestion? |
@tdejager Could you check the implementation for the uv part? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
@ruben-arts The warning message was updated as you suggested. |
Looks good let's merge! |
This pr add new config keys:
Activate the configured proxies at the entrypoint of pixi subcommands, like the
https.proxy
config keys forgit
.With these configs, when developing multiple projects, we can setup different proxies for each projects, and do not need to write the config into
pixi.toml
[activation]
sections.The common proxy environments such as
HTTPS_PROXY
andhttp_proxy
can overridden the whole proxy config table, so behaviors of the proxy injection via env are kept.This pr could help the similar situations in #2757 , #1035, #474, etc.