Skip to content

Remove LI check in GDPR consent handler #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Remove LI check in GDPR consent handler #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/main/java/org/sharedid/endpoint/consent/GdprConsentString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,6 @@ private boolean isV2ConsentGiven(int vendorId) {
return false;
}

boolean hasLegitimateInterest = tcString.getVendorLegitimateInterest().contains(vendorId);

if (!hasLegitimateInterest) {
return false;
}

//Cory (4/6/2020): Ignoring LI transparency fields for now...

boolean hasPublisherRestrictions = tcString.getPublisherRestrictions().stream().anyMatch(publisherRestriction -> {
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/sharedid/endpoint/handler/CheckGdprConsentHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void setup() {

when(metricRegistry.meter(anyString())).thenReturn(meter);

handler = new CheckGdprConsentHandler(metricRegistry, 52);
handler = new CheckGdprConsentHandler(metricRegistry, 887);
}

@Test
Expand Down Expand Up @@ -105,7 +105,7 @@ public void testMalformedGdprString(Vertx vertx, VertxTestContext context) {
public void testGdprConsentStringGranted() throws Exception {
when(routingContext.response()).thenReturn(response);

String consentString = "COuQACgOuQACgM-AAAENAPCAAIAAAIAAAAAAAjQAQAaACNABABoACEgAgA0A";
String consentString = "CPC1ggVPC1ggVM-AAAENBQCAAIAAAAAAAAAAG7wAQG7gAAAA";

GdprConsentString gdprConsentString =
new GdprConsentString(consentString);
Expand Down