Skip to content

AndBeyond.Media adapter: update bidder code #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 11, 2022

Conversation

AndBeyondMediaHB
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 1f58c6e
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/633c2cb54ef5300009e565cf
😎 Deploy Preview https://deploy-preview-4018--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AndBeyondMediaHB AndBeyondMediaHB changed the title AndBeyond.Media adapter: update title AndBeyond.Media adapter: update bidder code Sep 16, 2022
@bretg
Copy link
Contributor

bretg commented Sep 27, 2022

@AndBeyondMediaHB - you have a case problem here. Unix is case sensitive and everything needs to match:

  1. your actual PBJS bid adapter file name is andBeyondMediaBidAdapter.js -- mixed case
  2. the biddercode in the adapter is all lowercase https://github.com/prebid/Prebid.js/pull/9005/files
  3. the biddercode in this docs PR is lowercase

The download page works by looking for the biddercode from this file and trying to build it. There's no such adapter as andbeyondmedia.js. It's andBeyondMediaBidAdapter.js

Please update the PRs to make the case consistent however you prefer.

@bretg
Copy link
Contributor

bretg commented Oct 4, 2022

ok - changing the biddercode to "beyondmedia" for Prebid.js will solve the website download problem, but now you've introduced another problem -- you're not matching the biddercode for your server-side adapter.

I'm afraid I have to insist that your client-side and server-side bidder code match. Publishers need to be able to use the Server-to-Server testing module, which they wouldn't be able to do for your service if you've got different codes for these adapters. Let's get this right.

Will let you choose whether to use "beyondmedia" or "andbeyondmedia" - just settle on one please. And if desired, you can define an alias on either or both client- and server-sides to use both names!

@AndBeyondMediaHB
Copy link
Contributor Author

ok - changing the biddercode to "beyondmedia" for Prebid.js will solve the website download problem, but now you've introduced another problem -- you're not matching the biddercode for your server-side adapter.

I'm afraid I have to insist that your client-side and server-side bidder code match. Publishers need to be able to use the Server-to-Server testing module, which they wouldn't be able to do for your service if you've got different codes for these adapters. Let's get this right.

Will let you choose whether to use "beyondmedia" or "andbeyondmedia" - just settle on one please. And if desired, you can define an alias on either or both client- and server-sides to use both names!

@bretg Thanks, we decided to keep the name beyondmedia.
prebid/prebid-server#2408

@bretg
Copy link
Contributor

bretg commented Oct 6, 2022

Prebid.js PR - prebid/Prebid.js#9005
Prebid Server (GoLang) PR - prebid/prebid-server#2408

@AndBeyondMediaHB - do you have existing clients using the name "andbeyondmedia"? If so, you'll need to add an alias or this will be considered a breaking change.

@AndBeyondMediaHB
Copy link
Contributor Author

Prebid.js PR - prebid/Prebid.js#9005 Prebid Server (GoLang) PR - prebid/prebid-server#2408

@AndBeyondMediaHB - do you have existing clients using the name "andbeyondmedia"? If so, you'll need to add an alias or this will be considered a breaking change.

we don't have clients

@AndBeyondMediaHB
Copy link
Contributor Author

@bretg
If none of our partners has used the adapter yet, can we change the bidderCode without any problems ?
If this is true, could you confirm that it is good ?)

@bretg
Copy link
Contributor

bretg commented Oct 11, 2022

Confirmed the code release went out with 7.19

@bretg bretg merged commit 287e309 into prebid:master Oct 11, 2022
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* add andBeyondMedia adapter

* update bidderCode

* fix title

* update biddercode

* biddercode andbeyond.media => andbeyond

* updates

* updates

Co-authored-by: Vlad Isaiko <[email protected]>
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
* add andBeyondMedia adapter

* update bidderCode

* fix title

* update biddercode

* biddercode andbeyond.media => andbeyond

* updates

* updates

Co-authored-by: Vlad Isaiko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants