-
Notifications
You must be signed in to change notification settings - Fork 1.3k
AndBeyond.Media adapter: update bidder code #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@AndBeyondMediaHB - you have a case problem here. Unix is case sensitive and everything needs to match:
The download page works by looking for the biddercode from this file and trying to build it. There's no such adapter as andbeyondmedia.js. It's andBeyondMediaBidAdapter.js Please update the PRs to make the case consistent however you prefer. |
ok - changing the biddercode to "beyondmedia" for Prebid.js will solve the website download problem, but now you've introduced another problem -- you're not matching the biddercode for your server-side adapter. I'm afraid I have to insist that your client-side and server-side bidder code match. Publishers need to be able to use the Server-to-Server testing module, which they wouldn't be able to do for your service if you've got different codes for these adapters. Let's get this right. Will let you choose whether to use "beyondmedia" or "andbeyondmedia" - just settle on one please. And if desired, you can define an alias on either or both client- and server-sides to use both names! |
@bretg Thanks, we decided to keep the name beyondmedia. |
Prebid.js PR - prebid/Prebid.js#9005 @AndBeyondMediaHB - do you have existing clients using the name "andbeyondmedia"? If so, you'll need to add an alias or this will be considered a breaking change. |
we don't have clients |
@bretg |
Confirmed the code release went out with 7.19 |
* add andBeyondMedia adapter * update bidderCode * fix title * update biddercode * biddercode andbeyond.media => andbeyond * updates * updates Co-authored-by: Vlad Isaiko <[email protected]>
* add andBeyondMedia adapter * update bidderCode * fix title * update biddercode * biddercode andbeyond.media => andbeyond * updates * updates Co-authored-by: Vlad Isaiko <[email protected]>
No description provided.