dchain module docs #3439
Merged
dchain module docs #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Made a few minor updates. I do have a general question about this module though -- why is it that Prebid.js is able to add a node to the end of the DChain? It seems to me that the bidders should be doing that themselves. Seems like we could end up with duplicates for responsible bidders.
patmmccann
approved these changes
Jan 21, 2022
|
I think Jason's code covers Bret's concern. I believe the module only establishes a dchain when the dchain is missing. |
jlaso
pushed a commit
to AuDigent/prebid.github.io
that referenced
this pull request
Nov 6, 2024
* dchain module docs * added example, word smithing Co-authored-by: bretg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit late (apologies), but this PR represents the docs tied around the new dchain module available for Prebid.js
The module code was already merged via prebid/Prebid.js#7473
I would appreciate any feedback/word-smithing on this PR by interested parties, as describing the business justifications and need for publishers is not exactly my forte.
If there's any other information needed or other back-end pages that need to be updated to properly reflect this page as a module in the new style of prebid.org, please let me know. I tried to look around to current examples and past PRs, and I didn't believe anything else should be needed than cleanly defining the headers.