Skip to content

adding setBidderConfig #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2019
Merged

adding setBidderConfig #1589

merged 2 commits into from
Nov 6, 2019

Conversation

bretg
Copy link
Contributor

@bretg bretg commented Nov 4, 2019

No description provided.

Copy link
Contributor

@jeanstemp jeanstemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some minor edits and I have one question about the note.

If any other bidder calls `getConfig('bidderA')`, it will receive nothing.

{: .alert.alert-info :}
The `setBidderConfig` function will soon be used by the `schain` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know when "soon" is? Will we remember to revise this note when that happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of weeks. Yes, I plan on remembering to change this note. Of course the memory isn't what it once was.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) Just wanted to make sure. I've seen a lot of docs that haven't been updated in years that say "new" or "coming soon". Thanks!

@jeanstemp jeanstemp merged commit 61fbc04 into master Nov 6, 2019
@bretg bretg deleted the setBidderConfig branch January 21, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants