Skip to content

Viewdeos DX adapter doc #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Viewdeos DX adapter doc #1511

merged 4 commits into from
Nov 6, 2019

Conversation

GeneGenie
Copy link
Contributor

No description provided.

@GeneGenie GeneGenie mentioned this pull request Sep 25, 2019
2 tasks
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm your adapter will read from mediaTypes.video.playerSize and update this doc.

// Video instream adUnit
{
code: 'div-test-div',
sizes: [[640, 480]],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a deprecated attribute. the recommendation is to put the player size in mediaTypes.video.playerSize: [640, 480]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed!

@bretg
Copy link
Contributor

bretg commented Oct 30, 2019

will be part of 2.39

@bretg bretg merged commit 8828441 into prebid:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants