Skip to content

Add cleanmedia bidder code #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2019
Merged

Add cleanmedia bidder code #1078

merged 2 commits into from
Jan 10, 2019

Conversation

sa1omon
Copy link
Contributor

@sa1omon sa1omon commented Jan 7, 2019

No description provided.

harpere
harpere approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harpere harpere added the LGTM label Jan 7, 2019
bretg
bretg requested changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to rename gambid to gamoshi? Looking into the PR it appears you want all three codes to work:

  code: 'gamoshi',
  aliases: ['gambid', 'cleanmedia'],

This makes me think that you don't want to rename gambid to gamoshi, but add a gamoshi?

@bretg bretg added needs work and removed LGTM labels Jan 8, 2019
@bretg bretg mentioned this pull request Jan 8, 2019
Merged
1 task
@sa1omon
Copy link
Contributor Author

sa1omon commented Jan 8, 2019

@bretg I want to rename gambid to gamoshi but for backward compliance I didn't remove gambid entirely. I will remove gambid soon.

@bretg
Copy link
Contributor

bretg commented Jan 10, 2019

for backward compliance I didn't remove gambid entirely

Sorry, not understanding because github diffs show that gambid.md is renamed:

dev-docs/bidders/gambid.md → dev-docs/bidders/gamoshi.md

@sa1omon
Copy link
Contributor Author

sa1omon commented Jan 10, 2019

for backward compliance I didn't remove gambid entirely

Sorry, not understanding because github diffs show that gambid.md is renamed:

dev-docs/bidders/gambid.md → dev-docs/bidders/gamoshi.md

@bretg Sorry, my mistake. I have added the file now. thanks

@harpere
Copy link
Contributor

harpere commented Jan 10, 2019

all requested changes have been made. merging.

@harpere harpere merged commit ebeceee into prebid:master Jan 10, 2019
@sa1omon sa1omon deleted the gamoshi_new_aliases_branch branch January 16, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg requested changes

@harpere harpere harpere approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sa1omon @bretg @harpere