Rise: Add test mode param #4308
Conversation
Code coverage summaryNote:
riseRefer here for heat map coverage report |
|
@pm-shriprasad-marathe can you please review? |
adapters/rise/rise.go
Outdated
| for _, imp := range openRTBRequest.Imp { | ||
| var bidderExt adapters.ExtImpBidder | ||
| if err = jsonutil.Unmarshal(imp.Ext, &bidderExt); err != nil { | ||
| return "", fmt.Errorf("unmarshal bidderExt: %w", err) | ||
| return bidderParameters, fmt.Errorf("unmarshal bidderExt: %w", err) |
There was a problem hiding this comment.
@SamuelRise : Why there is a need to return empty reference &bidderParameters{}. Why can't we return nil instead?
In my opinion, we are creating unnecessary reference in memory
There was a problem hiding this comment.
@ShriprasadM thanks for the comment, fixed
| @@ -5,4 +5,5 @@ type ImpExtRise struct { | |||
| PublisherID string `json:"publisher_id"` | |||
| Org string `json:"org"` | |||
| PlacementID string `json:"placementId"` | |||
| TestMode bool `json:"testMode"` | |||
There was a problem hiding this comment.
@SamuelRise : Being its impression level parameter, curious to understand how testEndpointURL and endpointURL will work in following scenario -
{
"imp": [
{
"id": "imp_1",
"ext": {
"prebid": {
"bidder": {
"rise": {
"testMode": true
}
}
}
}
},
{
"id": "imp_2",
"ext": {
"prebid": {
"bidder": {
"rise": {
"testMode": false
}
}
}
}
}
]
}There was a problem hiding this comment.
@ShriprasadM in this case we will check the first imp that will decide on whether to use "testMode"
| "testMode": { | ||
| "type": "boolean", | ||
| "description": "Test mode" |
There was a problem hiding this comment.
@SamuelRise : how req.test and this parameter will work together?
There was a problem hiding this comment.
@ShriprasadM we only decide through the 'testMode' parameter the end point url so not really sure what you mean
Code coverage summaryNote:
riseRefer here for heat map coverage report |
|
Why is a "test mode" necessary? Testing should be performed on a non-prod or local instance. |
Uh oh!
There was an error while loading. Please reload this page.