Skip to content

Kobler: Remove sensitive device and user data #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Conversation

TommyHPettersen
Copy link
Contributor

Small change to the Kobler adapter to remove any sensitive data from the requests

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 33184f3

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		80.6%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:103:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:134:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:149:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:163:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:170:	sanitizeDevice		100.0%
total:									(statements)		91.0%

@bsardo bsardo changed the title Kobler: removed sensitive data from device and user Kobler: Remove sensitive device and user data Apr 22, 2025
@bsardo bsardo added the adapter label Apr 22, 2025
@bsardo
Copy link
Collaborator

bsardo commented Apr 28, 2025

@pm-jaydeep-mohite can you please review?

}

func sanitizeDevice(device openrtb2.Device) *openrtb2.Device {
device.IP = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add device != nil check ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added now

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5431c20

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:36:	MakeRequests		80.6%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:103:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:134:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:149:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:163:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	sanitizeDevice		100.0%
total:									(statements)		91.2%

Copy link
Contributor

@pm-jaydeep-mohite pm-jaydeep-mohite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TommyHPettersen
Copy link
Contributor Author

@VeronikaSolovei9 Hello, can we have a 2nd review on this soon? It's a small change and we were hoping to get this released as soon as possible, thank you!

@przemkaczmarek przemkaczmarek self-assigned this Jun 4, 2025
@bsardo bsardo merged commit 419d602 into prebid:master Jun 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants