-
Notifications
You must be signed in to change notification settings - Fork 816
Kobler: Remove sensitive device and user data #4295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code coverage summaryNote:
koblerRefer here for heat map coverage report
|
@pm-jaydeep-mohite can you please review? |
} | ||
|
||
func sanitizeDevice(device openrtb2.Device) *openrtb2.Device { | ||
device.IP = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add device != nil
check ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added now
Code coverage summaryNote:
koblerRefer here for heat map coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@VeronikaSolovei9 Hello, can we have a 2nd review on this soon? It's a small change and we were hoping to get this released as soon as possible, thank you! |
Small change to the Kobler adapter to remove any sensitive data from the requests