Skip to content

IX: merge eventtrackers with imptrackers for native bid responses #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 1, 2021
Merged

IX: merge eventtrackers with imptrackers for native bid responses #1900

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5fb13a9
IX: merge eventtrackers with imptrackers for native bid responses
manigandham Jun 24, 2021
6d08585
IX: add check to ensure event trackers of method=image
manigandham Jun 24, 2021
599dd76
handle native 1.1 and 1.2 payloads, add json tests
manigandham Jun 24, 2021
dd3a033
update json tests for native 1.1 and 1.2 ad markup
manigandham Jun 24, 2021
5b21652
check json.marshal for errors, ignore rewrite if so
manigandham Jun 29, 2021
49a2f18
simplify `if` by checking `len` only
manigandham Jun 29, 2021
5b9895b
use map of empty structs instead of bool
manigandham Jun 29, 2021
1fa55b7
added tests for missing native and eventtrackers objects
manigandham Jun 29, 2021
8ec79ba
fix variable naming
manigandham Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions adapters/ix/ix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
"io/ioutil"
"net/http"

"github.com/mxmCherry/openrtb/v15/native1"
native1response "github.com/mxmCherry/openrtb/v15/native1/response"
"github.com/mxmCherry/openrtb/v15/openrtb2"
"github.com/prebid/prebid-server/adapters"
"github.com/prebid/prebid-server/config"
Expand Down Expand Up @@ -417,6 +419,34 @@ func (a *IxAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalReque
}
}

var bidNative *native1response.Response
if bidType == openrtb_ext.BidTypeNative {
unmarshalExtErr := json.Unmarshal([]byte(bid.AdM), &bidNative)
if unmarshalExtErr == nil && bidNative.EventTrackers != nil && len(bidNative.EventTrackers) > 0 {

// create unique list of imp pixels urls from `imptrackers` and `eventtrackers`
uniqueImpPixels := map[string]bool{}
for _, v := range bidNative.ImpTrackers {
uniqueImpPixels[v] = true
}

for _, v := range bidNative.EventTrackers {
if v.Event == native1.EventTypeImpression {
uniqueImpPixels[v.URL] = true
}
}

// rewrite `imptrackers` with new deduped list of imp pixels
bidNative.ImpTrackers = make([]string, len(uniqueImpPixels))
for k := range uniqueImpPixels {
bidNative.ImpTrackers = append(bidNative.ImpTrackers, k)
}

json, _ := json.Marshal(bidNative)
bid.AdM = string(json)
}
}

bidderResponse.Bids = append(bidderResponse.Bids, &adapters.TypedBid{
Bid: &bid,
BidType: bidType,
Expand Down