Adds preferDeals support #1528
Merged
Adds preferDeals support #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Oct 12, 2020
exchange/auction.go
Outdated
| @@ -125,6 +125,19 @@ func newAuction(seatBids map[openrtb_ext.BidderName]*pbsOrtbSeatBid, numImps int | |||
| } | |||
| } | |||
|
|
|||
| // Calculate if the new bid (nbid) will win against the current winning bid (wbid) given preferDeals. | |||
| func isNewWinningBid(nbid, wbid *openrtb.Bid, preferDeals bool) bool { | |||
There was a problem hiding this comment.
Consider changing the variable names to be more obvious:
nbid -> bid (i think the 'new' part is implied)
wbid -> winningBid
SyntaxNode
previously approved these changes
Oct 13, 2020
SyntaxNode
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1355