Fix Test TestEventChannel_OutputFormat #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Sep 1, 2020
| eventChannel.Push([]byte("two")) | ||
| eventChannel.flush() | ||
|
|
||
| time.Sleep(10 * time.Millisecond) |
There was a problem hiding this comment.
Consider moving the sleep before the flush (and Close call in TestEventChannelPushAndClose) to ensure the messages are pushed before calling flush.
| eventChannel.Push([]byte("two")) | ||
| eventChannel.flush() | ||
|
|
||
| time.Sleep(10 * time.Millisecond) |
There was a problem hiding this comment.
Could we change this to 1 ms? If we need to sleep due wait for go routines, IMHO it should be a minimal amount of time.
added 2 commits
September 2, 2020 10:04
SyntaxNode
approved these changes
Sep 2, 2020
mansinahar
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestEventChannel_OutputFormatfound inanalytics/pubstack/eventchannel/eventchannel_test.gois sometimes failing, specially when run by Travis, very likely because of the concurrent functionality of theEventChannelmethods. This PR corrects said test case and adds assertions.