Skip to content

NoBid Bid Adapter: support for Floors #9635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 14, 2023

Conversation

redaguermas
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Added support for Floors for the NoBid Bid Adapter.

redaguermas and others added 18 commits March 4, 2020 15:39
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
# Conflicts:
#	test/spec/modules/nobidBidAdapter_spec.js
@ChrisHuie ChrisHuie changed the title NoBid Bid Adapter: Support for Floors NoBid Bid Adapter: support for Floors Mar 8, 2023
@ChrisHuie
Copy link
Collaborator

@redaguermas looks like you included your code editor files. If you could please remove those 🙏

@redaguermas
Copy link
Contributor Author

I only checked in 3 files: nobidBidAdapter.js, nobidBidAdapter.md and nobidBidAdapter_spec.js.
I am not seeing other files in "fe57afa"

@ChrisHuie
Copy link
Collaborator

I only checked in 3 files: nobidBidAdapter.js, nobidBidAdapter.md and nobidBidAdapter_spec.js. I am not seeing other files in "fe57afa"

🤷‍♂️ Code editors sometimes do their own things so not sure the issue. This pr has 9 files changed though.

Removed IDE file.
Removed IDE file.
Delete strange file.
Delete file not needed.
@redaguermas
Copy link
Contributor Author

Sorry about that. I see now. It's strange how these files got in. I removed them. Thank you for bringing that to my attention.

@redaguermas
Copy link
Contributor Author

Hello.
Any update on this?

@bretg
Copy link
Collaborator

bretg commented Mar 13, 2023

docs PR prebid/prebid.github.io#4406

@ChrisHuie ChrisHuie self-assigned this Mar 14, 2023
@ChrisHuie ChrisHuie merged commit 32be3e8 into prebid:master Mar 14, 2023
mscottnelson added a commit to 33Across/Prebid.js that referenced this pull request Mar 31, 2023
* upstream/master:
  Prebid Server adapter: fledge support (prebid#9342)
  Taboola Bid Adapter: resolve AUCTION_PRICE macro (prebid#9735)
  Revert "IntentIQ Analytics Module : initial release (prebid#9322)" (prebid#9734)
  IntentIQ Analytics Module : initial release (prebid#9322)
  Increment version to 7.44.0-pre
  Prebid 7.43.0 release
  Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` (prebid#9660)
  Add 9 Dots Media alias (prebid#9699)
  Smaato: Adapters that accept geolocation data from bid parameters should also accept it from ortb2.(device|user).geo (prebid#9676) (prebid#9725)
  Adloox AdServer Video : lengthen test timeouts (prebid#9728)
  RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (prebid#9726)
  chore: update `getAudiencesAsBidderOrtb2` implementation and test (prebid#9720)
  CORE: allow to disable setting the pbjs global variable (prebid#9568)
  Display.io Bid Adapter: ad request parameters renaming, user session saving (prebid#9553)
  CORE:  add bid to winningBids when marking as used (prebid#9612)
  Concert Bid Adapter: enable support for GPP consent and remove user sync (prebid#9700)
  Sonobi Bid Adapter: add IntentIq Id (prebid#9649)
  added fix and support for multibid module (prebid#9602)
  Update Permutive RTD documentation (prebid#9697)
  Adkernel Bid Adapter: add adlive.io alias (prebid#9714)
  FPD Enrichment: use low entropy method by default to fetch user agent data (prebid#9711)
  GumGum Bid Adapter : send gpp data in bidrequest (prebid#9707)
  Adagio Bid Adapter : add new params `splitKeyword` and `dl` to bidRequest payload (prebid#9694)
  fix lint and test failures
  Increment version to 7.43.0-pre
  Prebid 7.42.0 release
  Fluct Bid Adapter: add user sync support (prebid#9651)
  VIS.X fix onTimeout data (prebid#9657)
  ShowHeroes Bid Adapter: added support for USP (prebid#9681)
  Core: improve FPD enrichment (prebid#9659)
  changed the URL (prebid#9698)
  Permutive RTD Module: migrate appnexus to ortb2 (prebid#9630)
  Disable describe.only and it.only (prebid#9693)
  DistroScale bidder enhancement (prebid#9641)
  minutemediaplus Bid Adapter - pass gpp, sua and bid data to server. (prebid#9637)
  LiveIntent UserId module: update LiveConnect dependency (prebid#9672)
  Criteo Bid Adapter: reinforce adomain type in case of missmatch (prebid#9687)
  SmartyTech Bid Adapter : add size parameters (prebid#9692)
  Revert "Nativo Bid Adapter: adding UserId support (prebid#9583)" (prebid#9691)
  GDPR consent management: accept static config without `getTCData` (prebid#9664)
  Kulturemedia Bid Adapter: New Adapter (prebid#9613)
  Nativo Bid Adapter: adding UserId support (prebid#9583)
  Underdog Media Bid Adapter: Switch request to method to POST (prebid#9547)
  ZetaGlobalSsp: provide schain (prebid#9678)
  Next Millennium Bid Adapter : added `imp[].id` required parameter for openrtb 2.5 request. (prebid#9675)
  Increment version to 7.42.0-pre
  Prebid 7.41.0 release
  DFP video adserver module: set `description_url` to pub's URL by default; do not skip setting it if `cache.url` is set (prebid#9665)
  support the timeout parameter in the conversant adapter (prebid#9673)
  Browsi Bid Adapter: initial release (prebid#9562)
  feat(permutiveRtd): add `ix` and custom cohort `ortb2.user.data` (prebid#9631)
  Freewheel SSP Adapter: add prebid version in ad request (prebid#9667)
  Yandex Bid Adapter: (prebid#9604)
  Bump webpack from 5.74.0 to 5.76.0 (prebid#9668)
  Deleted the default empty string from  userConsent argument in the module's  init-function. (prebid#9663)
  AdUp Technology bid adapter: avoid modification of bid request (prebid#9656)
  NoBid Bid Adapter: support for Floors (prebid#9635)
  Freewheel SSP Bid Adapter : support userIdAsEids (prebid#9655)
  Missena: add userEids, add network and cpm to tracking (prebid#9645)
  IX Bid Adapter: update additional consent field (prebid#9650)
  Aduptech Bid Adapter : add GVLID (prebid#9658)
  Core: make video cache timeout configurable (prebid#9578)
  Delete flocIdSystem.js (prebid#9652)
  TheMediaGrid Bid Adapter : support gpp (prebid#9629)
  Stv Bid Adapter : initial adapter release (prebid#9533)
  CleanMediaNet Bid Adapter : add userid support and update testing (prebid#9608)
  Update creative.html (prebid#9648)
  PubWise Bid Adapter: support video and improve tests (prebid#9576)
  Increment version to 7.41.0-pre
  Prebid 7.40.0 release
  Rubicon Bid Adapter: add size 1x2 (prebid#9644)
  main>modules\neuwoRtdProvider.js > apiUrl format handling improved, removed unnecessary parameter integrationExamples\gpt\neuwoRtdProvider_example.html > fixed render-step handling on warning (prebid#9646)
  Core: fix native render when adUnits defines `mediaTypes.native.ortb` but adapter replies with "legacy" native bid (prebid#9638)
  kueezRtb Bid Adapter: pass sua data to server. (prebid#9643)
  update Mediago & Discovery BidAdapter:remove size filter (prebid#9585)
  Permutive RTD Module: migrate magnite to ortb2 (prebid#9555)
  Vidazoo Bid Adapter: pass sua params. (prebid#9636)
  ADJS-1271-send-envelope-param-for-lexicon (prebid#9634)
  Nexx360 Bid Adapter: native support added and ortbConverter usage (prebid#9626)
  PBjs Core: do not rely on an extendable `window.Promise` (prebid#9558)
  TheMediaGrid Bid Adapters : do not use jwp segments from bid.rtd field (prebid#9627)
  read video size from playerSize (prebid#9625)
  Lemma Digital Bid Adapter : initial adapter release (prebid#9532)
  smallfix on response validation (prebid#9623)
  Updated adf adapter to support native with type; use ortb request for natives (prebid#9616)
  kargo adapter - adding prebid version to requests (prebid#9620)
  Rubicon bid adapter: remove pchain support (prebid#9621)
  trigger build
  revert
  tag out markWinningBidAsUsed entirely
  remove unnecessary feature tag
  tag out ORTB video conversion utils
  tag out video-related code in native.js
  tag out video-related code in renderAd
  replace callPrebidCache with getHook result
  tag out adpod-related logic
  Define "VIDEO" compile time feature flag
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* Enable supplyChain support

* Added support for COPPA

* rebuilt

* Added support for Extended User IDs.

* Added support for the "meta" attribute in bid response.

* Added support for Floors to the NoBid Prebid Adapter.

* Delete .project

Removed IDE file.

* Delete .jsdtscope

Removed IDE file.

* Delete org.eclipse.wst.jsdt.ui.superType.container

Removed IDE file.

* Delete org.eclipse.wst.jsdt.ui.superType.name

Removed IDE file.

* Delete a

Delete strange file.

* Delete nobidBidAdapter.js.orig

Delete file not needed.

---------

Co-authored-by: Reda Guermas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants