Skip to content

DiscoveryDSP Bid Adapter: initial adapter release #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Sep 8, 2022
Merged

DiscoveryDSP Bid Adapter: initial adapter release #8876

merged 26 commits into from
Sep 8, 2022

Conversation

cuihua111
Copy link
Contributor

@cuihua111 cuihua111 commented Aug 22, 2022 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'DiscoveryDSP',
  params: {
      token: "03d467db07075683b0c373b6b3d3113c",
      media: "ppnews.com"
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title DiscoveryDSP Bid Adapter:new adapter DiscoveryDSP Bid Adapter: initial adapter release Aug 22, 2022
@bear-pond
Copy link

Docs PR: prebid/prebid.github.io#3970

@cuihua111
Copy link
Contributor Author

Please tell me when my pr will be reviewed?thx

@ChrisHuie
Copy link
Collaborator

@cuihua111 can you please remove your change to the package-lock file please.

@ChrisHuie ChrisHuie requested a review from mmoschovas August 25, 2022 12:01
@cuihua111
Copy link
Contributor Author

cuihua111 commented Aug 25, 2022 •
edited
Loading

@ChrisHuie ok，I have deleted it，thanks

@cuihua111
Copy link
Contributor Author

Please review again

mmoschovas
mmoschovas reviewed Aug 31, 2022
View reviewed changes
mmoschovas
mmoschovas reviewed Aug 31, 2022
View reviewed changes
mmoschovas
mmoschovas reviewed Aug 31, 2022
View reviewed changes
@cuihua111
Copy link
Contributor Author

@mmoschovas hi mmoschovas,I've amended each of the comments above, is there any chance of them being incorporated in this version?

mmoschovas
mmoschovas reviewed Sep 1, 2022
View reviewed changes
mmoschovas
mmoschovas reviewed Sep 1, 2022
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2022

This pull request introduces 1 alert when merging 30554f0 into d739446 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

mmoschovas
mmoschovas approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@mmoschovas mmoschovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes. lgtm

@mmoschovas
Copy link
Contributor

@cuihua111 the build process here is failing, and we wont be able to merge without this running successfully. Can you please review?

@cuihua111
Copy link
Contributor Author

cuihua111 commented Sep 2, 2022 •
edited
Loading

@mmoschovas I may know the reason and have modified it.

@yuzujin
Copy link

yuzujin commented Sep 5, 2022

@mmoschovas hi mmoschovas, please code review again，we hope to reach the publishers as soon as possible，please！

@cuihua111
Copy link
Contributor Author

@mmoschovas Hi, mmoschovas, I'm not sure if I need to go through the circleCI process again, so can you help me in the review? Since I want to be merged in this version, please help me to confirm it as early as possible. Thanks!

@cuihua111
Copy link
Contributor Author

@mmoschovas Hi, mmoschovas, I'm not sure if I need to go through the circleCI process again, so can you help me in the review? Since I want to be merged in this version, please help me to confirm it as early as possible. Thanks!

@ChrisHuie Can you please manually turn on the circleCI process again?

@mmoschovas
Copy link
Contributor

Sorry going to need @ChrisHuie for this one. But once that runs successfully we can merge

@cuihua111
Copy link
Contributor Author

@ChrisHuie Please tell me when can this pr be merged?

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Sep 8, 2022 •
edited
Loading

@ChrisHuie Please tell me when can this pr be merged?

Resubmitting right now under my account to kick off tests. Looks like there are a few linting errors here so will document what I update in the new pr and fix in this pr. Planning to merge this in today 👍

@ChrisHuie ChrisHuie mentioned this pull request Sep 8, 2022
Closed
@patmmccann patmmccann merged commit 9b4baf1 into prebid:master Sep 8, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@cuihua111 @ChrisHuie
@patmmccann @JacobKlein26
DiscoveryDSP Bid Adapter: initial adapter release (prebid#8876)
8fcc4a3 
* discovery Bid Adapter:new adapter

* discovery Bid Adapter:new adapter

* fix lint

* change bidder name & fix circleCI lint

* fix lint

* fix lint

* add bidWon report

* delete package-lock.json

* update discoveryBidAdapter

* add meta.advertiserDomains

* Optimisation bidResponse

* fix Spelling errors :(

* add ttl into bidResponse :(

* kick off circleci tests manually

* for kick off circleci

* update markdown

* Update discoveryBidAdapter.md

* kick off tests

* fix linting

Co-authored-by: v_cuidong <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@cuihua111 @ChrisHuie
@patmmccann @jorgeluisrocha
DiscoveryDSP Bid Adapter: initial adapter release (prebid#8876)
f781481 
* discovery Bid Adapter:new adapter

* discovery Bid Adapter:new adapter

* fix lint

* change bidder name & fix circleCI lint

* fix lint

* fix lint

* add bidWon report

* delete package-lock.json

* update discoveryBidAdapter

* add meta.advertiserDomains

* Optimisation bidResponse

* fix Spelling errors :(

* add ttl into bidResponse :(

* kick off circleci tests manually

* for kick off circleci

* update markdown

* Update discoveryBidAdapter.md

* kick off tests

* fix linting

Co-authored-by: v_cuidong <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoschovas mmoschovas mmoschovas approved these changes

Assignees

@ChrisHuie ChrisHuie

@mmoschovas mmoschovas

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cuihua111 @bear-pond @ChrisHuie @mmoschovas @yuzujin @patmmccann