Skip to content

Yieldlift Bid Adapter: improve adomain #8708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

yieldlift
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie
Copy link
Collaborator

@yieldlift can you please pull in recent commits? This branch is super far behind. That should also hopefully fix the testing issues

@patmmccann patmmccann changed the title Yieldlift adomain Yieldlift Bid Adapter: improve adomain Jul 19, 2022
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

# Conflicts:
#	modules/yieldliftBidAdapter.js
#	test/spec/modules/yieldliftBidAdapter_spec.js
@ChrisHuie ChrisHuie self-assigned this Jul 21, 2022
@ChrisHuie ChrisHuie merged commit 16b74a7 into prebid:master Jul 21, 2022
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* added meta.adomain

* Changing adomain parameter to advertiserDomains

* Merging master into branch

Co-authored-by: Danijel Predarski <[email protected]>
ccorbo pushed a commit to ccorbo/Prebid.js that referenced this pull request Jul 27, 2022
* added meta.adomain

* Changing adomain parameter to advertiserDomains

* Merging master into branch

Co-authored-by: Danijel Predarski <[email protected]>
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* added meta.adomain

* Changing adomain parameter to advertiserDomains

* Merging master into branch

Co-authored-by: Danijel Predarski <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* added meta.adomain

* Changing adomain parameter to advertiserDomains

* Merging master into branch

Co-authored-by: Danijel Predarski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants