-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Yieldlift Bid Adapter: improve adomain #8708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yieldlift can you please pull in recent commits? This branch is super far behind. That should also hopefully fix the testing issues |
patmmccann
approved these changes
Jul 19, 2022
patmmccann
previously requested changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts
# Conflicts: # modules/yieldliftBidAdapter.js # test/spec/modules/yieldliftBidAdapter_spec.js
ChrisHuie
approved these changes
Jul 21, 2022
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* added meta.adomain * Changing adomain parameter to advertiserDomains * Merging master into branch Co-authored-by: Danijel Predarski <[email protected]>
ccorbo
pushed a commit
to ccorbo/Prebid.js
that referenced
this pull request
Jul 27, 2022
* added meta.adomain * Changing adomain parameter to advertiserDomains * Merging master into branch Co-authored-by: Danijel Predarski <[email protected]>
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* added meta.adomain * Changing adomain parameter to advertiserDomains * Merging master into branch Co-authored-by: Danijel Predarski <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* added meta.adomain * Changing adomain parameter to advertiserDomains * Merging master into branch Co-authored-by: Danijel Predarski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information