-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Videonow Bid Adapter: Initial Bid Adapter Release #8669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ChrisHuie @patmmccann Hi! Needs review. |
FYI. @gwhigs @regulyarniy I kicked off tests manually on this pr because the CircleCI tests didn't automatically run. This is usually do to a fork being followed instead of Prebid master branch. So if there are updates likely will need to manually kick off again 👍 |
I deleted a line of white space, this triggered circleci |
@ChrisHuie @patmmccann Could somebody please review and merge as it seems @gwhigs busy for some time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, working in testing.
* Videonow bid adapter: add videonow bid adapter * Update videonowBidAdapter.md Co-authored-by: Patrick McCann <[email protected]>
* Videonow bid adapter: add videonow bid adapter * Update videonowBidAdapter.md Co-authored-by: Patrick McCann <[email protected]>
Type of change
Description of change
Videonow Bidder Adapter for Prebid.js.
Use
videonow
as bidder:Params
pId
required, profile IDcurrency
optional, currency, default is 'RUB'url
optional, for debug, bidder urlcodeType
optional, for debug, yhb codeTypeAdUnits configuration example
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: