Skip to content

Videonow Bid Adapter: Initial Bid Adapter Release #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

regulyarniy
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Videonow Bidder Adapter for Prebid.js.

Use videonow as bidder:

Params

  • pId required, profile ID
  • currency optional, currency, default is 'RUB'
  • url optional, for debug, bidder url
  • codeType optional, for debug, yhb codeType

AdUnits configuration example

    var adUnits = [{
      code: 'your-slot', //use exactly the same code as your slot div id.
      mediaTypes: {
          banner: {
              sizes: [[640, 480]]
          }
      },
      bids: [{
        bidder: 'videonow',
        params: { 
            pId: '1234',
            currency: 'RUB',
        }
      }]
    }];

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@regulyarniy
Copy link
Contributor Author

@ChrisHuie @patmmccann Hi! Needs review.

@ChrisHuie ChrisHuie changed the title New adapter: Videonow Videonow Bid Adapter: Initial Bid Adapter Release Jul 11, 2022
@ChrisHuie ChrisHuie requested a review from gwhigs July 12, 2022 11:55
@ChrisHuie
Copy link
Collaborator

FYI. @gwhigs @regulyarniy I kicked off tests manually on this pr because the CircleCI tests didn't automatically run. This is usually do to a fork being followed instead of Prebid master branch. So if there are updates likely will need to manually kick off again 👍

@patmmccann
Copy link
Collaborator

I deleted a line of white space, this triggered circleci

@regulyarniy
Copy link
Contributor Author

@ChrisHuie @patmmccann Could somebody please review and merge as it seems @gwhigs busy for some time?

@patmmccann patmmccann removed the request for review from gwhigs July 25, 2022 16:55
@patmmccann patmmccann requested a review from Rothalack July 25, 2022 16:55
Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing.

@Rothalack Rothalack merged commit fbcecc9 into prebid:master Jul 27, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* Videonow bid adapter: add videonow bid adapter

* Update videonowBidAdapter.md

Co-authored-by: Patrick McCann <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* Videonow bid adapter: add videonow bid adapter

* Update videonowBidAdapter.md

Co-authored-by: Patrick McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants