Prebid Core: refactor bidderSettings to have only one entry point #7712
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import {deepAccess, mergeDeep} from './utils.js'; | ||
| import {getGlobal} from './prebidGlobal.js'; | ||
|
|
||
| const CONSTANTS = require('./constants.json'); | ||
|
|
||
| export function ScopedSettings(getSettings, defaultScope) { | ||
|
There was a problem hiding this comment. I'm not big fan of OOP concept. In modules we have exported functions (that can be used in other modules/bidders) and private functions that are used only inside that module. There was a problem hiding this comment. Is there a reason to not using Class if you choose OOP? There was a problem hiding this comment.
Because when I started working on this IE11 was still a target :) I don't have a strong preference on the syntax, I can rewrite using
Then some day I'll have to explain to you why you're wrong. But more seriously, I don't understand how you can say we barely use OOP - config, auctionManager, auction, adapterManager, adapters, etc are all objects with capabilities. Is the problem that I use There was a problem hiding this comment.
Yes, totally :) |
||
| this.getSettings = getSettings; | ||
| this.defaultScope = defaultScope; | ||
| } | ||
|
|
||
| /** | ||
| * Get setting value at `path` under the given scope, falling back to the default scope if needed. | ||
| * If `scope` is `null`, get the setting's default value. | ||
| * @param scope {String|null} | ||
| * @param path {String} | ||
| * @returns {*} | ||
| */ | ||
| ScopedSettings.prototype.get = function (scope, path) { | ||
| let value = this.getOwn(scope, path); | ||
| if (typeof value === 'undefined') { | ||
| value = this.getOwn(null, path); | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| /** | ||
| * Get the setting value at `path` *without* falling back to the default value. | ||
| * @param scope {String} | ||
| * @param path {String} | ||
| * @returns {*} | ||
| */ | ||
| ScopedSettings.prototype.getOwn = function (scope, path) { | ||
| scope = this.resolveScope(scope); | ||
| return deepAccess(this.getSettings(), `${scope}.${path}`) | ||
| } | ||
|
|
||
| /** | ||
| * @returns {string[]} all existing scopes except the default one. | ||
| */ | ||
| ScopedSettings.prototype.getScopes = function () { | ||
| return Object.keys(this.getSettings()).filter((scope) => scope !== this.defaultScope); | ||
| } | ||
|
|
||
| /** | ||
| * @returns all settings in the given scope, merged with the settings for the default scope. | ||
| */ | ||
| ScopedSettings.prototype.settingsFor = function (scope) { | ||
| return mergeDeep({}, this.ownSettingsFor(null), this.ownSettingsFor(scope)); | ||
| } | ||
|
|
||
| /** | ||
| * @returns all settings in the given scope, *without* any of the default settings. | ||
| */ | ||
| ScopedSettings.prototype.ownSettingsFor = function (scope) { | ||
| scope = this.resolveScope(scope); | ||
| return this.getSettings()[scope] || {}; | ||
| } | ||
|
|
||
| ScopedSettings.prototype.resolveScope = function (scope) { | ||
| if (scope == null) { | ||
| return this.defaultScope; | ||
| } else { | ||
| return scope; | ||
| } | ||
| } | ||
|
|
||
| export const bidderSettings = new ScopedSettings(() => getGlobal().bidderSettings || {}, CONSTANTS.JSON_MAPPING.BD_SETTING_STANDARD); | ||
Uh oh!
There was an error while loading. Please reload this page.