Prebid Core: Fix Media Type Price Granularity #7607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 867b2e6 into 2a4f678 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging db688eb into 2a4f678 - view on LGTM.com new alerts:
|
msm0504
approved these changes
Oct 26, 2021
ChrisHuie
approved these changes
Oct 27, 2021
1 task
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
* pass bidReq into targeting function and other fun stuff * pass through bidReq * allow granularity override * Superfluous argument passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Media Type Price Granularity has not really been working as expected since its adoption.
Whichever bid came back first (its mediaType) would be used for all price bucket targeting for that page load.
We need the logic to grab the correct priceGran to run on each adServerTargeting execute.
think this fixes #6545