Skip to content

Sovrn: Pass the imp.ext.deals field #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Sovrn: Pass the imp.ext.deals field #6098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
64a1715
EX-2549 Pass segments parameter as imp.ext.dealids array
egsgordeev Dec 7, 2020
d8b8d28
EX-2549 Address Jon's feedback
egsgordeev Dec 8, 2020
21c5ac7
EX-2549 Reworked the solution
egsgordeev Dec 8, 2020
20a3c53
EX-2549 Blackbird compatibility
egsgordeev Dec 8, 2020
2b452a0
EX-2549 Address Jon's comments
egsgordeev Dec 8, 2020
8dc7356
Merge pull request #26 from sovrn/EX-2549_deal_id_custom_param
egsgordeev Dec 8, 2020
9b76c96
Merge remote-tracking branch 'upstream/master' into EX-2549_address_u…
egsgordeev Dec 9, 2020
f58d355
EX-2549 Addressed upstream PR comments
egsgordeev Dec 9, 2020
bc94810
Merge pull request #28 from sovrn/EX-2549_address_upstream_comments
egsgordeev Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions modules/sovrnBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const spec = {
bidSizes = ((utils.isArray(bidSizes) && utils.isArray(bidSizes[0])) ? bidSizes : [bidSizes])
bidSizes = bidSizes.filter(size => utils.isArray(size))
const processedSizes = bidSizes.map(size => ({w: parseInt(size[0], 10), h: parseInt(size[1], 10)}))
sovrnImps.push({
const imp = {
adunitcode: bid.adUnitCode,
id: bid.bidId,
banner: {
Expand All @@ -63,7 +63,17 @@ export const spec = {
},
tagid: String(utils.getBidIdParameter('tagid', bid.params)),
bidfloor: utils.getBidIdParameter('bidfloor', bid.params)
});
}

const segmentsString = utils.getBidIdParameter('segments', bid.params)

if (segmentsString) {
imp.ext = {
deals: segmentsString.split(',').map(deal => deal.trim())
}
}

sovrnImps.push(imp);
});

const page = bidderRequest.refererInfo.referer
Expand Down
26 changes: 26 additions & 0 deletions test/spec/modules/sovrnBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,32 @@ describe('sovrnBidAdapter', function() {
expect(data.user.ext.tpid[0].uid).to.equal('A_CRITEO_ID')
expect(data.user.ext.prebid_criteoid).to.equal('A_CRITEO_ID')
});

it('should ignore empty segments', function() {
const payload = JSON.parse(request.data)
expect(payload.imp[0].ext).to.be.undefined
})

it('should pass the segments param value as trimmed deal ids array', function() {
const segmentsRequests = [{
'bidder': 'sovrn',
'params': {
'segments': ' test1,test2 '
},
'adUnitCode': 'adunit-code',
'sizes': [
[300, 250],
[300, 600]
],
'bidId': '30b31c1838de1e',
'bidderRequestId': '22edbae2733bf6',
'auctionId': '1d1a030790a475'
}];
const request = spec.buildRequests(segmentsRequests, bidderRequest)
const payload = JSON.parse(request.data)
expect(payload.imp[0].ext.deals[0]).to.equal('test1')
expect(payload.imp[0].ext.deals[1]).to.equal('test2')
})
});

describe('interpretResponse', function () {
Expand Down