Skip to content

added onBidWon event #5679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 16, 2020
Merged

added onBidWon event #5679

merged 8 commits into from
Sep 16, 2020

Conversation

adxpremium
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

onBidWon event

robertrmartinez
robertrmartinez requested changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but please add a unit test.

@adxpremium
Copy link
Contributor Author

adxpremium commented Sep 9, 2020 •
edited
Loading

Looks fine, but please add a unit test.

@robertrmartinez Done :)

@adxpremium adxpremium closed this Sep 9, 2020
@adxpremium adxpremium reopened this Sep 9, 2020
robertrmartinez
robertrmartinez requested changes Sep 9, 2020
View reviewed changes
test/spec/modules/luponmediaBidAdapter_spec.js Outdated
'status': 'rendered'
};

spec.onBidWon(bids);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not actually test anything.

See this https://github.com/prebid/Prebid.js/blob/master/test/spec/modules/adpartnerBidAdapter_spec.js#L199 example.

From Line 199 and on.

You can see they trigger the spec.onBidWon but are validating the return, as well as stubbing the request and making sure it has the right data they expect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertrmartinez we just made the change that you suggested.

@robertrmartinez
Copy link
Collaborator

Please remove / revert the package-lock.json file from the staged commits and we can merge this

@adxpremium
Copy link
Contributor Author

Please remove / revert the package-lock.json file from the staged commits and we can merge this

@robertrmartinez Done

@robertrmartinez robertrmartinez merged commit a3aa5f4 into prebid:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adxpremium @robertrmartinez