-
Notifications
You must be signed in to change notification settings - Fork 2.2k
welect: update parameters to match backend specs of tcf2.0 #5613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nduitz Looks good, just wanted to mention that GVL ID is not specified. So, if the GDPR Enforcement is included in the build, your adapter may get blocked (If the publisher has listed your adapter under vendorExceptions
, it won't).
@nduitz Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fawke sorry I am currently on vacation. I'll look into this by the end of next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fawke thanks for pointing it out, I added our gvlid to the spec
@nduitz Can you also add the key, This change was introduced from this PR: prebid/prebid.github.io#2271. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fawke prebid/prebid.github.io@3096faa
thank you, done <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
This changes the parameter parsing to our backend, so we are working only with tcf2.0 parameters
Documentation update:
prebid/prebid.github.io#2233