Skip to content

Conversant bid adapter to use userIdAsEids #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Mar 16, 2020

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • [ X ] Refactoring (no functional changes, no api changes)

Note

  • We need confirmation from the Conversant team ( @sohlhausen @pycnvr ) before merging this change.

Description of change

Making changes in Conversant bid adapter to use userIdAsEids
Refer: https://github.com/prebid/Prebid.js/blob/master/modules/userId/eids.md
Please note that for TDID, I have added ext field as well, I referred prebidServerBidAdapter for that.
Old format was

{
        source: 'adserver.org',
        uids: [{
            id: 'some-random-id-value',
            atype: 1
        }]
    }

New format is

{
        source: 'adserver.org',
        uids: [{
            id: 'some-random-id-value',
            atype: 1,
            ext: {
                rtiPartner: 'TDID'
            }
        }]
    }

@pycnvr
Copy link
Collaborator

pycnvr commented Mar 11, 2020

LGTM. Thanks for the update.

@pm-harshad-mane
Copy link
Contributor Author

Thanks, @pycnvr for the swift response.

@pm-harshad-mane
Copy link
Contributor Author

Hello @jsnellbaker ,
Could you please review this PR?

@jsnellbaker jsnellbaker merged commit 2db8ecf into prebid:master Mar 16, 2020
@pm-harshad-mane
Copy link
Contributor Author

Thank you @jsnellbaker and @idettman

bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* using userIdAsEids
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* using userIdAsEids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants