-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversant bid adapter to use userIdAsEids #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM. Thanks for the update. |
Thanks, @pycnvr for the swift response. |
Hello @jsnellbaker , |
idettman
approved these changes
Mar 13, 2020
jsnellbaker
approved these changes
Mar 16, 2020
Thank you @jsnellbaker and @idettman |
bmwcmw
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Mar 31, 2020
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * using userIdAsEids
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * using userIdAsEids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note
Description of change
Making changes in Conversant bid adapter to use
userIdAsEids
Refer: https://github.com/prebid/Prebid.js/blob/master/modules/userId/eids.md
Please note that for TDID, I have added ext field as well, I referred prebidServerBidAdapter for that.
Old format was
New format is