Skip to content

33Across adding bidder specific extension field #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

33Across adding bidder specific extension field #4298

merged 2 commits into from
Oct 15, 2019

Conversation

thomas-33across
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding new field into 33Across specific extension field

@bretg bretg self-assigned this Oct 14, 2019
bretg
bretg requested changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix broken unit tests. Apparently many of them do 'deep equals' and the new value changes things up.

bretg
bretg approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bretg bretg merged commit c3ba14c into prebid:master Oct 15, 2019
@pm-manasi-moghe pm-manasi-moghe mentioned this pull request Jan 13, 2021
Merged
10 tasks
@pm-manasi-moghe pm-manasi-moghe mentioned this pull request Jan 25, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees

@bretg bretg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-33across @bretg