Adding workflow to run end to end tests #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
changed the title
jaiminpanchal27
changed the title
jsnellbaker
reviewed
Oct 4, 2019
There was a problem hiding this comment.
@jaiminpanchal27 These changes look good overall. Had a question though on one point.
.circleci/config.yml
Outdated
|
|
||
| - &run_endtoend_test | ||
| name: BrowserStack End to end testing | ||
| command: echo "Running end to end test using workflows" |
There was a problem hiding this comment.
Can you clarify how this command starts the e2e test process? I don't see the normal gulp e2e command in this file and this command appears to just print the noted text.
There was a problem hiding this comment.
I used echo to verify workflow. Updated the command now
added 2 commits
October 7, 2019 15:06
…rkflow # Conflicts: # .circleci/config.yml
jsnellbaker
approved these changes
Oct 8, 2019
jsnellbaker
added
needs 2nd review
|
LGTM |
Fawke
approved these changes
Oct 8, 2019
robertrmartinez
approved these changes
Oct 8, 2019
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds a new circleci job to run end to end tests every night on master branch. Job to run unit tests remains same. I have updated the config to use circleci workflow and aliases
Why run once every night ?
Please see https://circleci.com/gh/prebid/workflows/Prebid.js for past successful runs of both jobs.