Skip to content

Rubi Analytics handles > 1 bidResponse per bidRequest #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

robertrmartinez
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

We found out that some bid adapters are sending back multiple bidResponses for a single bidRequest.

So to handle it we will now be picking the top CPM for any bidRequest with many bidResponses.

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bretg bretg merged commit d79483b into master Sep 26, 2019
@robertrmartinez robertrmartinez deleted the rubi_analytics_top_bid branch September 21, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants