Skip to content

Add video dimensions in request #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 18, 2019
Merged

Add video dimensions in request #4174

merged 12 commits into from
Sep 18, 2019

Conversation

EMXDigital
Copy link
Contributor

Type of change

  • [X ] Other

Description of change

Adding video.h and video.w to each video request from our adapter from the playerSize provided.

@Fawke
Copy link
Contributor

Fawke commented Sep 12, 2019

@EMXDigital
Command gulp test is failing, seems like a problem in your unit test file. Can you fix it please. I've attached the screenshot for your reference. Thanks.
Screenshot 2019-09-12 at 10 37 52 AM

@EMXDigital
Copy link
Contributor Author

Thank you for pointing this out! The latest commit fixes this.

@Fawke Fawke merged commit ebf4272 into prebid:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants