videoNow bid adapter

[sdbaron]

Type of change

• [x ] New bidder adapter

Description of change

new bidder adapter for videoNow

• test parameters for validating bids

   {
      code: 'banner-div',
      mediaTypes: {
        banner: {
          sizes: [[640, 480], [336, 280]]
        }
      },
      bids: [{
         bidder: 'videonow',
         params: {
           pId: 1,
           placementId: 'div-001'
         }
       }]
   }

• contact email of the adapter’s maintainer
• [x ] official adapter submission

[sumit116]

Hi @sdbaron,
I am getting 404 Not Found error when hitting the url https://bidder.videonow.ru/prebid?profile_id=1. I am making request from India with the following request payload: {"id":"2b9273013ea69d","sizes":[[640,480],[336,280]],"cur":"RUB","placementId":"div-001","ref":"http://localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"}

Please check at your end.

[sdbaron]

Hi @sdbaron,
I am getting 404 Not Found error when hitting the url https://bidder.videonow.ru/prebid?profile_id=1. I am making request from India with the following request payload: {"id":"2b9273013ea69d","sizes":[[640,480],[336,280]],"cur":"RUB","placementId":"div-001","ref":"http://localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"}

Please check at your end.

Hi!
Indeed, we had some problems with this URL, but now it should work correctly.

[sumit116]

Please make the suggested changes. I found unit test coverage is very low (~41%). Can you add more tests to increase it to at least 80%?

[sumit116]

can we use utils.logError() here?

[sumit116]

Can you please explain what does this function do and why do we need it in the adapter?

[sumit116]

unit test coverage is very low.

[sumit116]

Hi @sdbaron, could you work on the above feedback or do you have any questions?

[sdbaron]

Hi @sumit116, I had a vacation for a week, but now I’ve returned to work and will make corrections in a couple of days.