Provide deterministic behavior for sort function. #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#120112151]
|
@CarsonBanov |
| @@ -141,6 +141,9 @@ function getWinningBidTargeting() { | |||
| return winners; | |||
|
|
|||
| function getHighestCpm(previous, current) { | |||
| if (previous.cpm == current.cpm) { | |||
[#120112151]
[#120112151]
|
@mkendall07 Updated. |
|
@CarsonBanov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkendall07
The current behavior for sorting the bids (not actually sorting, just picking the highest) does not handle the case in which bids are equal/tied. This leads to non-deterministic behavior in picking the highest bid.
The addition provided in this PR has two goals. 1) Make the behavior of the sort function deterministic so an identical algorithm implemented elsewhere using the raw bid data will return the same results. 2) Use the existing
timeToRespondas a secondary sorting key which has the added benefit of slightly incentivizing faster bids while still being simple to implement.For our project we have been noticing a sizable amount of equal bids, so this issue actually occurs quite frequently. This would help publishers doing their own logging to better match Prebid (since the algorithm will now be deterministic) and it will enable bidders to get a better read on why a bid won/lost at a certain price.
.cc @mmilleruva