OpenX: Bugfix/update custom floors #3658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimee02
approved these changes
Mar 20, 2019
bretg
approved these changes
Mar 21, 2019
pycnvr
pushed a commit
to conversant/Prebid.js
that referenced
this pull request
Apr 4, 2019
* [BID-3477] - Update customFloor value * [BID-3477] - Update test spec
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* [BID-3477] - Update customFloor value * [BID-3477] - Update test spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When there is a customFloor with more than 3 decimals the adapter is passing a float when it should be an integer. This change rounds the customFloor to 2 decimal places before converting to CPM micros.