-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add 'hb_cache_host' and 'hb_cache_path' targeting for video bids when cache is set #3652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'hb_cache_host' and 'hb_cache_path' targeting for video bids when cache is set #3652
Conversation
}); | ||
|
||
// Adding hb_cache_host + hb_cache_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if mediaType is video,
And cache.url is defined,
Every bidResponse object will now contain hb_cache_host
and hb_cache_path
in the adServerTargeting
.
Sounds good to me.
And if an adapter had also previously specified these two values in its bidResponseObject, then we take it as is instead of overriding with the client side cache.url.
This satisfies the scenario where some bidders use a server side cache and others use client side.
LGTM.
@@ -505,6 +506,19 @@ function setupBidTargeting(bidObject, bidderRequest) { | |||
} | |||
|
|||
export function getStandardBidderSettings(mediaType) { | |||
// factory for key value objs | |||
function createKeyVal(key, value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea!
can anyone explain or link to what the |
https://github.com/prebid/prebid-video-cache-redirector/blob/master/motivation.md |
Prebid Cache Redirector ServiceGit repo: https://github.com/prebid/prebid-video-cache-redirector DFP imposes a limit on publishers entering in a video VAST tag URL... the The solution we chose is for
To support the use case of separate line items for each bidder, the VAST tag URL could contain the bidder-specific key-value-pairs:
|
Type of change
Description of change
When setConfig.cache.url is defined, pass hb_cache_host to ad server. We need hb_cache_host set to trigger the new Prebid video cache redirector, and we may as well send hb_cache_path as well. Both host and path are parsed from the prebid config cache property: config.getConfig('cache.url').
Use case:
The general idea is straight-forward: when cache.url is specified, parse it and add hb_cache_host and hb_cache_path to the targeting variables.