add default sizes value for appnexus native requests #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
approved these changes
Mar 1, 2019
jaiminpanchal27
added
LGTM
needs 2nd review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This change adds a 1x1 default size for native placements in the UT request when the
sizesfield is otherwise empty.Context
When sending bid requests to the UT endpoint that target a multi-format placement (eg banner + native), depending on the setup of the adUnit - the
sizesinformation is not included into the request.One example happens when you're only requesting for a native bid against a multi-format placement; since
sizesaren't typically associated with native bids - thesizesfield is left empty.When sizes information is empty but it's expected, the UT request returns an
{error: parse}response.The
[1, 1]size is commonly associated for native requests, so it was recommended to set this size to address the error returned by this type of situation.