update fun-hooks to latest and update api #3574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feature was added in: snapwich/fun-hooks#2 |
harpere
added
needs review
needs 2nd review
…fun-hooks # Conflicts: # package-lock.json # package.json
1 task
jaiminpanchal27
approved these changes
Feb 26, 2019
|
@jsnellbaker Please verify #3574 and update |
jsnellbaker
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Based on my local tests in trying to setup a hook as described in #3574, it appears to be working with these updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added a new feature to
fun-hooksthat allows you to add/removebeforeandafterhooks before the hookable function is actually defined. Added notes on the feature here: https://github.com/snapwich/fun-hooks#namingUpdated Prebid.js to use the new API which replaces the
hooksobject with a.getmethod to grab the hookable function. If the hookable function is not found it will create a placeholder for all thebefore/afterhooks until the hookable function is created. It's allows you to "subscribe" to hooks you expect to eventually be present, in a sense. Any hooks that are added using.getbut never eventually have a hookable function created for them will throw a warning when.readyis called (because at that point you are saying you expect all hookable functions to be created).@jsnellbaker check this out and see if it helps with the issue that prompted #3564
Also includes fix from #3544