PBS Bid Adapter oRTB caching and video updates #3528

idettman · 2019-02-06T20:21:58Z

Type of change

Other

Description of change

Changes to the prebidServerBidAdapter were needed to support S2S video:

When trying to do S2S video, we need the ability to:

Set request.ext.prebid.cache.vastxml to cache XML
request.ext.prebid.targeting.includewinners: true
request.ext.prebid.targeting.includebidderkeys: false
Without these, the openrtb won't work for video.

Several changes are needed to the prebidServerBidAdapter:

s2sConfig extPrebid support: merge into request.ext.prebid
making response.ext.prebid.cache values available to prebidjs core, renderers, and analytics adapters
append adserverTargeting to response bidObj if defined, the buildDfpVideoUrl function in dpfAdServerVideo will add it's properties as additional targeting, including hb_cache_host, hb_cache_path, hb_cache_path_rubicon, hb_cache_host_rubicon

Other information

Per cache requirements

…quirements

# Conflicts: # modules/prebidServerBidAdapter/index.js # modules/rubiconBidAdapter.js # test/spec/modules/prebidServerBidAdapter_spec.js # test/spec/modules/rubiconBidAdapter_spec.js

…cludewinners value

modules/prebidServerBidAdapter/index.js

…che_path, since the hb_cache_hostpath will be suppressed soon

idettman · 2019-02-08T16:24:22Z

Latest changes from ticket have been applied and ready for review

mkendall07

@idettman thanks for adding this feature!
Just had a few questions. Thanks!
Cc: @harpere

mkendall07 · 2019-02-20T20:43:33Z

modules/prebidServerBidAdapter/index.js

+        prebid: {
+          targeting: {
+            // includewinners is always true for openrtb
+            includewinners: true,


pardon my ignorance here, but are either of these flags a breaking change?

I do not think so,

I believe they just instruct PBS what to do with the ext.prebid.targeting.adServerTargeting response object.

includewinners: true ==> hb_{} keys are passed back

includebidderkeys: true ==> hb_{}_{bidder} keys are passed back

We set the latter to false to keep the number of KVPs down.
@bretg Can confirm maybe?

thanks, that makes sense.

mkendall07 · 2019-02-20T20:45:36Z

modules/prebidServerBidAdapter/index.js

+
+          // If ext.prebid.targeting exists, add it as a property value named 'adserverTargeting'
+          if (extPrebidTargeting && typeof extPrebidTargeting === 'object') {
+            bidObject.adserverTargeting = extPrebidTargeting;


what's the use case for PBS setting the keys into Prebid.js? AFAIK this is only for mobile use case where the client doesn't process the bids => keys.

There are additional KVPs that need to be copied through to the ad server, all utilized by the Prebid Universal Creative:

hb_cache_host

hb_cache_path

hb_winurl (not there yet, but will be)

I see thanks for clarifying. I wonder if PBJS should be setting these then? Because there could be a case where PBS isn't involved but universal creative is being used.

I realized after commenting while the above is true, you most likely won't need either _host or _path unless you are using AMP or prebid mobile, both of which are powered by PBS. So this most likely safe.

mkendall07 · 2019-02-20T20:52:33Z

Added @hhhjort for a quick review as well.

idettman · 2019-03-04T21:36:38Z

@hhhjort Can you review sometime today as we're trying to get into the release tomorrow.

hhhjort

Looks good to me.

robertrmartinez

LGTM!

…3018_pbs-adapter-enhancements-RE

…change should make it unnecessary

idettman · 2019-03-05T17:52:03Z

We did some extra testing and found an issue. When buildVideoUrl calls getAllTargeting and there are two bid response objects, it was constructing the adServerTargeting object to change the hb_uuid and hb_cache_id to be arrays containing both bidders uuids. We traced it to getAllWinningBids and we implemented a fix in auction.js. Basically we are adding those two keys as standardTargeting values when mediaType === video.

We implemented a fix in src/constants.js and src/auction.js, but we're waiting for re-review before merging.

jsnellbaker · 2019-03-05T18:52:40Z

I did some additional testing based on the above comment and the fix that was implemented appears to be working; the bids are properly generating the values for the hb_cache_id and hb_uuid keys.

Isaac Dettman added 16 commits November 1, 2018 11:20

updates to both the rubicon adapter and the prebid server for ORTB re…

539cf59

…quirements

updates to bid and auction data to reflect oRTB structure

1ab0300

merged pbjs commits

b880ee8

Merge branch 'master' into HB-3018_pbs-adapter-enhancements

35b938a

# Conflicts: # modules/prebidServerBidAdapter/index.js # modules/rubiconBidAdapter.js # test/spec/modules/prebidServerBidAdapter_spec.js # test/spec/modules/rubiconBidAdapter_spec.js

reverted karma conf

83eea00

always add ext.prebid.targeting.includewinners: true for openrtb

46cee5a

add unit test for ext.prebid.targeting.includewinners for openrtb

f56e72a

added s2sConfig 'video.ext.prebid' support and unit test

1ddea22

added code comments for changes to ORTB

99a8344

handle response.ext.prebid.cache values and added unit test

ab2da6d

update to merged video.ext.prebid with request.ext.prebid

8ebebe8

update to merge includewinners

9779105

added test for override used in s2sConfig for ext.prebid.targeting.in…

6da900e

…cludewinners value

fixes for response cache logic

cd5655f

added support for targeting cache props HB-3740

c164d9e

added test for adserverTargeting change

df76400

harpere reviewed Feb 7, 2019

View reviewed changes

modules/prebidServerBidAdapter/index.js Outdated Show resolved Hide resolved

harpere reviewed Feb 7, 2019

View reviewed changes

modules/prebidServerBidAdapter/index.js Outdated Show resolved Hide resolved

harpere self-assigned this Feb 7, 2019

harpere added needs review needs update labels Feb 7, 2019

Isaac Dettman added 2 commits February 7, 2019 14:27

updates to address Jira ticket revision

1b38dba

update to build the vastUrl object by utilizing hb_cache_host + hb_ca…

f7c0ec8

…che_path, since the hb_cache_hostpath will be suppressed soon

merged with remote changes

9737618

idettman removed the needs update label Feb 13, 2019

removed single quotes around object literal keys to match formatting

7351dee

idettman added the needs 2nd review Core module updates require two approvals from the core team label Feb 19, 2019

idettman requested review from jsnellbaker and mkendall07 February 19, 2019 19:54

mkendall07 reviewed Feb 20, 2019

View reviewed changes

mkendall07 requested a review from hhhjort February 20, 2019 20:52

bretg mentioned this pull request Feb 20, 2019

s2sConfig updates prebid/prebid.github.io#1164

Merged

mkendall07 approved these changes Feb 27, 2019

View reviewed changes

hhhjort approved these changes Mar 4, 2019

View reviewed changes

idettman removed the needs 2nd review Core module updates require two approvals from the core team label Mar 5, 2019

robertrmartinez approved these changes Mar 5, 2019

View reviewed changes

jsnellbaker approved these changes Mar 5, 2019

View reviewed changes

jsnellbaker added LGTM and removed needs review labels Mar 5, 2019

idettman added the on hold label Mar 5, 2019

added new standard targeting keys for video

05daa05

idettman added on hold and removed on hold labels Mar 5, 2019

Isaac Dettman added 2 commits March 5, 2019 09:43

Merge branch 'master' of https://github.com/prebid/Prebid.js into HB-…

584fa70

…3018_pbs-adapter-enhancements-RE

removed code added by jsnellbaker per his recommendation because our …

2fad94e

…change should make it unnecessary

idettman removed the on hold label Mar 5, 2019

idettman requested review from robertrmartinez and jsnellbaker March 5, 2019 18:54

jsnellbaker approved these changes Mar 5, 2019

View reviewed changes

robertrmartinez approved these changes Mar 5, 2019

View reviewed changes

idettman merged commit 9d5b9b4 into prebid:master Mar 5, 2019

jsnellbaker mentioned this pull request Mar 6, 2019

fix hb_cache_id for adpod bids #3617

Merged

1 task

idettman deleted the HB-3018_pbs-adapter-enhancements branch March 18, 2019 18:30

PBS Bid Adapter oRTB caching and video updates #3528

PBS Bid Adapter oRTB caching and video updates #3528

Uh oh!

Conversation

idettman commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Changes to the prebidServerBidAdapter were needed to support S2S video:

Other information

Uh oh!

Uh oh!

Uh oh!

idettman commented Feb 8, 2019

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

mkendall07 Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

robertrmartinez Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

mkendall07 Feb 27, 2019

Choose a reason for hiding this comment

Uh oh!

mkendall07 Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

bretg Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

mkendall07 Feb 27, 2019

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Feb 20, 2019

Uh oh!

idettman commented Mar 4, 2019

Uh oh!

hhhjort left a comment

Choose a reason for hiding this comment

Uh oh!

robertrmartinez left a comment

Choose a reason for hiding this comment

Uh oh!

idettman commented Mar 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsnellbaker commented Mar 5, 2019

Uh oh!

Uh oh!

idettman commented Feb 6, 2019 •

edited

Loading

bretg Feb 20, 2019 •

edited

Loading

idettman commented Mar 5, 2019 •

edited

Loading